QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: Roman Kiryanov <rkir@google.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	alex.bennee@linaro.org,  QEMU Developers <qemu-devel@nongnu.org>,
	JP Cottin <jpcottin@google.com>,
	 Erwin Jansen <jansene@google.com>,
	Mehdi Alizadeh <mett@google.com>
Subject: Re: Hermetic virtio-vsock in QEMU
Date: Wed, 17 Apr 2024 12:31:41 -0700	[thread overview]
Message-ID: <CAOGAQerx0DmHvJNf05wuJFOtXVwDFTt7fy0-GmBZ7xKoLAHTKQ@mail.gmail.com> (raw)
In-Reply-To: <Zh0NiI9ZfS5uzs5Z@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]

Hi Daniel,

thank you for looking into this. I checked how VHOST_USER_VSOCK and it
refers to the vhost-user protocol. It is implemented in the
subprojects/libvhost-user library, but this library depends on poll.h
and linux/vhost.h files. Do you know if it builds/works on Windows?

I checked how poll.h is used and the only reference I found is "VU_WATCH_IN
= POLLIN", no other VU_WATCH_* items seem to be used (the same applies to
G_IO_* in -glib.c). Maybe retire VU_WATCH_ and poll.h dependency?

For linux/vhost.h, I see it is gated by defined(__linux__)
in libvhost-user.c but not in libvhost-user.h and I think it is not used
in libvhost-user.

Regards,
Roman.


On Mon, Apr 15, 2024 at 4:20 AM Daniel P. Berrangé <berrange@redhat.com>
wrote:

> On Wed, Apr 03, 2024 at 02:30:33PM -0700, Roman Kiryanov wrote:
> > Hi Peter, Alex and QEMU,
> >
> > I work in Android Studio Emulator and we use virtio-vsock to emulate
> > devices (e.g. sensors) which live in the Emulator binary. We need to run
> on
> > Windows and in environments without CONFIG_VHOST_VSOCK, that is why we
> > cannot use vhost-vsock and invented our implementation. I tried to grep
> the
> > QEMU8 sources and I believe virtio-vsock is not available there.
> >
> > Do you think it is a good idea to implement virtio-vsock in QEMU (e.g. to
> > run on Windows)? If the answer is yes, could you please point where I
> could
> > start to build an upstreamable solution (not Android Emulator specific)?
> It
> > is not clear to me how we should make the device available for clients
> > (sensors, modem, adb, etc) in a generic way.
>
> This issue is proposing the idea of exposing VSOCK using AF_UNIX as the
> host backend, in a manner that's compatible with that used by firecracker
> and cloud-hypervisor:
>
>   https://gitlab.com/qemu-project/qemu/-/issues/2095
>
> Recent versions of Windows support AF_UNIX these days, so hopefully that
> would be satisfactory as an approach ?
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-
> https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|
>
>

[-- Attachment #2: Type: text/html, Size: 3377 bytes --]

  reply	other threads:[~2024-04-17 19:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 21:30 Hermetic virtio-vsock in QEMU Roman Kiryanov
2024-04-15 11:20 ` Daniel P. Berrangé
2024-04-17 19:31   ` Roman Kiryanov [this message]
2024-04-18  9:34     ` Daniel P. Berrangé
2024-05-07  8:10       ` Stefano Garzarella
2024-05-08  6:20         ` Roman Kiryanov
2024-05-08  7:49           ` Stefano Garzarella
2024-05-08  9:13             ` Marc-André Lureau
2024-05-08  9:38               ` Stefano Garzarella
2024-05-08 12:37                 ` Paolo Bonzini
2024-05-08 12:51                   ` Daniel P. Berrangé
2024-05-08 13:00                     ` Paolo Bonzini
2024-05-08 13:32                       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOGAQerx0DmHvJNf05wuJFOtXVwDFTt7fy0-GmBZ7xKoLAHTKQ@mail.gmail.com \
    --to=rkir@google.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=jansene@google.com \
    --cc=jpcottin@google.com \
    --cc=mett@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).