From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: dongwon.kim@intel.com
Cc: qemu-devel@nongnu.org, berrange@redhat.com, philmd@linaro.org
Subject: Re: [PATCH v12 6/6] ui/console: move QemuDmaBuf struct def to dmabuf.c
Date: Tue, 7 May 2024 17:37:49 +0400 [thread overview]
Message-ID: <CAMxuvazn_+Yg7+vc34D=ewo5Swz--d6cKH41F9A3QwkyePWxHw@mail.gmail.com> (raw)
In-Reply-To: <20240425015342.1033815-7-dongwon.kim@intel.com>
On Thu, Apr 25, 2024 at 5:58 AM <dongwon.kim@intel.com> wrote:
>
> From: Dongwon Kim <dongwon.kim@intel.com>
>
> To complete privatizing process of QemuDmaBuf, QemuDmaBuf struct def
> is moved to dmabuf.c
>
> Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/ui/dmabuf.h | 19 +------------------
> ui/dmabuf.c | 19 +++++++++++++++++++
> 2 files changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/include/ui/dmabuf.h b/include/ui/dmabuf.h
> index 4198cdf85a..dc74ba895a 100644
> --- a/include/ui/dmabuf.h
> +++ b/include/ui/dmabuf.h
> @@ -10,24 +10,7 @@
> #ifndef DMABUF_H
> #define DMABUF_H
>
> -typedef struct QemuDmaBuf {
> - int fd;
> - uint32_t width;
> - uint32_t height;
> - uint32_t stride;
> - uint32_t fourcc;
> - uint64_t modifier;
> - uint32_t texture;
> - uint32_t x;
> - uint32_t y;
> - uint32_t backing_width;
> - uint32_t backing_height;
> - bool y0_top;
> - void *sync;
> - int fence_fd;
> - bool allow_fences;
> - bool draw_submitted;
> -} QemuDmaBuf;
> +typedef struct QemuDmaBuf QemuDmaBuf;
>
> QemuDmaBuf *qemu_dmabuf_new(uint32_t width, uint32_t height,
> uint32_t stride, uint32_t x,
> diff --git a/ui/dmabuf.c b/ui/dmabuf.c
> index e047d5ca26..df7a09703f 100644
> --- a/ui/dmabuf.c
> +++ b/ui/dmabuf.c
> @@ -10,6 +10,25 @@
> #include "qemu/osdep.h"
> #include "ui/dmabuf.h"
>
> +struct QemuDmaBuf {
> + int fd;
> + uint32_t width;
> + uint32_t height;
> + uint32_t stride;
> + uint32_t fourcc;
> + uint64_t modifier;
> + uint32_t texture;
> + uint32_t x;
> + uint32_t y;
> + uint32_t backing_width;
> + uint32_t backing_height;
> + bool y0_top;
> + void *sync;
> + int fence_fd;
> + bool allow_fences;
> + bool draw_submitted;
> +};
> +
> QemuDmaBuf *qemu_dmabuf_new(uint32_t width, uint32_t height,
> uint32_t stride, uint32_t x,
> uint32_t y, uint32_t backing_width,
> --
> 2.34.1
>
prev parent reply other threads:[~2024-05-07 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 1:53 [PATCH v12 0/6] ui/console: Private QemuDmaBuf struct dongwon.kim
2024-04-25 1:53 ` [PATCH v12 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0 dongwon.kim
2024-04-25 1:53 ` [PATCH v12 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers dongwon.kim
2024-05-07 13:29 ` Marc-André Lureau
2024-04-25 1:53 ` [PATCH v12 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead dongwon.kim
2024-04-25 1:53 ` [PATCH v12 4/6] ui/console: Use qemu_dmabuf_set_..() " dongwon.kim
2024-05-07 13:30 ` Marc-André Lureau
2024-04-25 1:53 ` [PATCH v12 5/6] ui/console: Use qemu_dmabuf_new() and free() " dongwon.kim
2024-05-07 13:36 ` Marc-André Lureau
2024-04-25 1:53 ` [PATCH v12 6/6] ui/console: move QemuDmaBuf struct def to dmabuf.c dongwon.kim
2024-05-07 13:37 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMxuvazn_+Yg7+vc34D=ewo5Swz--d6cKH41F9A3QwkyePWxHw@mail.gmail.com' \
--to=marcandre.lureau@redhat.com \
--cc=berrange@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).