From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6B1C47094 for ; Thu, 10 Jun 2021 13:21:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 741BC61374 for ; Thu, 10 Jun 2021 13:21:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 741BC61374 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrKcl-0001zm-JJ for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 09:21:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKYG-000104-W7 for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:16:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKYD-0001LY-Rc for qemu-devel@nongnu.org; Thu, 10 Jun 2021 09:16:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623331007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OfivHGgE85788EZIRMBUTPl2VV0X0BLgX4W7PYLnwHg=; b=TYAXZvBtlb/LjtDYA0eZap9bYXjxc2z/KBicgkqMc/PyVr+avglb9rTwPvtR5YB9DjVvG4 8zK5rzATjU2o6VTt38TFXSFOGosWT/uNSDcbXaPjYqAeXPH8ZVAlPLKsCw0fqYTDr09pxl kcb6zh6B61vTVkwcbcW35jcRkaqK9Rk= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-G4gMX2cYMzK6A9cUOMA8QA-1; Thu, 10 Jun 2021 09:16:45 -0400 X-MC-Unique: G4gMX2cYMzK6A9cUOMA8QA-1 Received: by mail-ot1-f70.google.com with SMTP id i25-20020a9d4a990000b0290304f00e3e3aso18290559otf.15 for ; Thu, 10 Jun 2021 06:16:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OfivHGgE85788EZIRMBUTPl2VV0X0BLgX4W7PYLnwHg=; b=H+89eWiueb2p8/lAMKOcoHpXItEEcybBnX4n+4+xzI3g5OAbyZ0pvxCRv5oMD8e7vd XMQI6sao1PQNAtZCEdu//g8AA30Gxw+TKrdF1CYOjBt6mJwtZCbYGu8PBYRxMGEoTiqT fjS4D59MYVbh3rlJcGOqkCyHT22bJDa6IKbRNWgs6dBpyk1ORWtGZijPrRNmIOy5jGpu dJLBL0V3QHFYEI8qCF5sBzoGaDjh+PdPn6ggjtvcx4dxvTJ82zE8JoHH8e91QGMlP0GF E+hhxLMpNyqoqGhNXVX16qg+pjCCxPXNk/6TDEViKjhLWe2dOk7XdsMzV7T2YvrBsSU2 PU0g== X-Gm-Message-State: AOAM5324WPMRqnykjHJZ1An3TaRAjIfPsVTHNpiteMdnTWA7OZ+Rie0z wHaxpiaUyXTq0C07s2/geBGMtr9uNSg1SKpOIwLWI1Kx59/T4RAZgfypaXnHsDUPgWI/MSr4QHE l96FS8jyNEQpDlPyr1EkhYWEJDO+uJe0= X-Received: by 2002:a9d:6081:: with SMTP id m1mr2454607otj.226.1623331004816; Thu, 10 Jun 2021 06:16:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQm3iCKt/aPrB0XaEWNuKfuX6wne3yM8Hg55bhhutUOUPwEm+ui/OfzinnCCJQ3rxOMhyzI3wyI9qfd0OQnL0= X-Received: by 2002:a9d:6081:: with SMTP id m1mr2454595otj.226.1623331004580; Thu, 10 Jun 2021 06:16:44 -0700 (PDT) MIME-Version: 1.0 References: <20210609180118.1003774-1-eblake@redhat.com> <20210609180118.1003774-3-eblake@redhat.com> In-Reply-To: From: Nir Soffer Date: Thu, 10 Jun 2021 16:16:27 +0300 Message-ID: Subject: Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context To: Eric Blake Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=nsoffer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=216.205.24.124; envelope-from=nsoffer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block , Markus Armbruster , QEMU Developers , Max Reitz , libguestfs@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 10, 2021 at 2:52 AM Nir Soffer wrote: > > On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: I posted a work in progress patch implementing support for qemu:joint-allocaition in oVirt: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197 The most important part is the nbd client: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197/1/daemon/ovirt_imageio/_internal/nbd.py With this our tests pass with qemu-nbd build with Eric patch: https://gerrit.ovirt.org/c/ovirt-imageio/+/115197/1/daemon/test/client_test.py We may need to use qemu:joint-allocation only for qcow2 images, and base:allocation for raw images, because allocation depth reporting is not correct for raw images. Since we control the qemu-nbd in both cases this should not be an issue. But it would be better if allocation depth would work for any kind of image, and we always use qemu:joint-allocation. Nir