From: Alistair Francis <alistair23@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Sia Jee Heng <jeeheng.sia@starfivetech.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
qemu-riscv@nongnu.org, imammedo@redhat.com, anisinha@redhat.com,
peter.maydell@linaro.org, shannon.zhaosl@gmail.com,
sunilvl@ventanamicro.com, palmer@dabbelt.com,
alistair.francis@wdc.com, bin.meng@windriver.com,
liwei1518@gmail.com, dbarboza@ventanamicro.com,
zhiwei_liu@linux.alibaba.com
Subject: Re: [PATCH v2 1/3] qtest: allow SPCR acpi table changes
Date: Mon, 13 May 2024 20:36:18 +1000 [thread overview]
Message-ID: <CAKmqyKP1fmvyNsY0uXasK7jdHK9C_cizJdiqivK=Nxtfo37OxA@mail.gmail.com> (raw)
In-Reply-To: <20240513023110-mutt-send-email-mst@kernel.org>
On Mon, May 13, 2024 at 4:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Mon, May 13, 2024 at 01:55:50PM +1000, Alistair Francis wrote:
> > On Tue, May 7, 2024 at 3:24 PM Sia Jee Heng
> > <jeeheng.sia@starfivetech.com> wrote:
> >
> > Can you describe why you are doing this and that it will be reverted
> > in the commit message?
> >
> > Alistair
>
> What motivation are you asking? This follows the normal acpi test update
> procedure.
I find it clearer to have commits describe that they are disabling
tests for a specific reason. That way it's easier to track what's
going on.
If ACPI test updates don't usually do that then that's fine with me
Alistair
>
> > >
> > > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com>
> > > ---
> > > tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > index dfb8523c8b..3f12ca546b 100644
> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > @@ -1 +1,3 @@
> > > /* List of comma-separated changed AML files to ignore */
> > > +"tests/data/acpi/virt/riscv64/SPCR",
> > > +"tests/data/acpi/virt/aarch64/SPCR",
> > > --
> > > 2.34.1
> > >
> > >
>
next prev parent reply other threads:[~2024-05-13 10:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 5:22 [PATCH v2 0/3] Upgrade ACPI SPCR table to support SPCR table version 4 format Sia Jee Heng
2024-05-07 5:22 ` [PATCH v2 1/3] qtest: allow SPCR acpi table changes Sia Jee Heng
2024-05-13 3:55 ` Alistair Francis
2024-05-13 6:31 ` Michael S. Tsirkin
2024-05-13 10:36 ` Alistair Francis [this message]
2024-05-14 9:22 ` Peter Maydell
2024-05-07 5:22 ` [PATCH v2 2/3] hw/acpi: Upgrade ACPI SPCR table to support SPCR table version 4 format Sia Jee Heng
2024-05-13 4:01 ` Alistair Francis
2024-05-13 5:16 ` Sunil V L
2024-05-14 11:16 ` JeeHeng Sia
2024-05-13 6:31 ` Michael S. Tsirkin
2024-05-14 11:18 ` JeeHeng Sia
2024-05-07 5:22 ` [PATCH v2 3/3] tests/qtest/bios-tables-test: Update virt SPCR golden references Sia Jee Heng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKP1fmvyNsY0uXasK7jdHK9C_cizJdiqivK=Nxtfo37OxA@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=anisinha@redhat.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=imammedo@redhat.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=liwei1518@gmail.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=sunilvl@ventanamicro.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).