From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: dongwon.kim@intel.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] ui/gtk: Draw guest frame at refresh cycle
Date: Tue, 7 May 2024 19:04:27 +0400 [thread overview]
Message-ID: <CAJ+F1C+JZ+vLWuY8QxvzPqFqY5neTYrjK6xnYN2b1weR_GPwZQ@mail.gmail.com> (raw)
In-Reply-To: <20240426225059.3871283-1-dongwon.kim@intel.com>
On Sat, Apr 27, 2024 at 2:56 AM <dongwon.kim@intel.com> wrote:
>
> From: Dongwon Kim <dongwon.kim@intel.com>
>
> Draw routine needs to be manually invoked in the next refresh
> if there is a scanout blob from the guest. This is to prevent
> a situation where there is a scheduled draw event but it won't
> happen bacause the window is currently in inactive state
> (minimized or tabified). If draw is not done for a long time,
> gl_block timeout and/or fence timeout (on the guest) will happen
> eventually.
>
> v2: Use gd_gl_area_draw(vc) in gtk-gl-area.c
>
> Suggested-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/gtk-egl.c | 1 +
> ui/gtk-gl-area.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index 3af5ac5bcf..75f6b9011a 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -150,6 +150,7 @@ void gd_egl_refresh(DisplayChangeListener *dcl)
> vc, vc->window ? vc->window : vc->gfx.drawing_area);
>
> if (vc->gfx.guest_fb.dmabuf && vc->gfx.guest_fb.dmabuf->draw_submitted) {
> + gd_egl_draw(vc);
> return;
> }
>
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 52dcac161e..4fff957c3f 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -126,6 +126,7 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl)
> gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : vc->gfx.drawing_area);
>
> if (vc->gfx.guest_fb.dmabuf && vc->gfx.guest_fb.dmabuf->draw_submitted) {
> + gd_gl_area_draw(vc);
> return;
> }
>
> --
> 2.34.1
>
>
--
Marc-André Lureau
prev parent reply other threads:[~2024-05-07 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 22:50 [PATCH v2] ui/gtk: Draw guest frame at refresh cycle dongwon.kim
2024-05-07 15:04 ` Marc-André Lureau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+F1C+JZ+vLWuY8QxvzPqFqY5neTYrjK6xnYN2b1weR_GPwZQ@mail.gmail.com \
--to=marcandre.lureau@gmail.com \
--cc=dongwon.kim@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).