From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Xu <peterx@redhat.com>
Cc: gaosong <gaosong@loongson.cn>, "Fabiano Rosas" <farosas@suse.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Tianrui Zhao" <zhaotianrui@loongson.cn>,
pbonzini@redhat.com, richard.henderson@linaro.org,
maobibo@loongson.cn, lixianglai@loongso.cn
Subject: Re: [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures
Date: Tue, 7 May 2024 16:52:35 +0100 [thread overview]
Message-ID: <CAFEAcA9vTfhakvVRTfRvtgxTxfADVARX5yHAKT6a1_QXAC4MgQ@mail.gmail.com> (raw)
In-Reply-To: <ZjpM-1MImDyQKyHI@x1n>
On Tue, 7 May 2024 at 16:47, Peter Xu <peterx@redhat.com> wrote:
>
> On Tue, May 07, 2024 at 04:12:34PM +0800, gaosong wrote:
> > Just remove CONIFG_KVM would be OK?
>
> You're the loongarch maintainer so I'd say your call. :)
>
> If you're not yet sure, IMHO we should go with the simplest, which is the
> original oneliner patch.
The original patch needs to also bump the version numbers when
it adds the new field.
Even when we do not wish to maintain migration compatibility,
bumping the version number means that users get a (more or less)
helpful error message if they try an unsupported cross-version
migration, rather than weird behaviour.
thanks
-- PMM
prev parent reply other threads:[~2024-05-07 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 1:23 [PATCH] target/loongarch/kvm: Fix VM recovery from disk failures Song Gao
2024-04-30 8:53 ` Philippe Mathieu-Daudé
2024-04-30 14:00 ` Fabiano Rosas
2024-05-01 15:45 ` Peter Xu
2024-05-02 12:45 ` Fabiano Rosas
2024-05-07 8:12 ` gaosong
2024-05-07 15:47 ` Peter Xu
2024-05-07 15:52 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9vTfhakvVRTfRvtgxTxfADVARX5yHAKT6a1_QXAC4MgQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=farosas@suse.de \
--cc=gaosong@loongson.cn \
--cc=lixianglai@loongso.cn \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).