From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D1FC47094 for ; Thu, 10 Jun 2021 09:30:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AA88613E3 for ; Thu, 10 Jun 2021 09:30:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AA88613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrH0y-00065u-1e for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 05:30:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrH0F-00052a-Gx for qemu-devel@nongnu.org; Thu, 10 Jun 2021 05:29:31 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:44760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrH0D-00056q-RC for qemu-devel@nongnu.org; Thu, 10 Jun 2021 05:29:31 -0400 Received: by mail-ed1-x532.google.com with SMTP id u24so32151752edy.11 for ; Thu, 10 Jun 2021 02:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tn1G0Psh9gBGfjtI+rLmwDa6qG5SqexuPEq6cTaj7mM=; b=zQbpmHF0pQYDIEw3RGq9mybvGmX454k3Tmvci7vLtU1uG9a9kIxDi/zvoP+w4od0jI 4444dVAi/tJPxHrZxd7O17iTU18usP51i7UhPFeyJbvdCdGWGUsfy9r9hk8I4tH3SQ9x vZWwN1beVgrWOM+BlPmvKH0qwgOUY1usk5A0c4/1Db2AtGL6J23YD1yazmfVzfRmsbMR I2AXLFiMS6T3aahmjlKVqIG3GI1DFYBOziRpin9pRmnffDMOEgFmLCDXeSd4fRX648Z5 e/gUfnUbPz0x6KJS03F2XNweiFRjBzOrT9qCLBHvGCUb6+8j3wP2Th4+VP8iYHl08bGj vrZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tn1G0Psh9gBGfjtI+rLmwDa6qG5SqexuPEq6cTaj7mM=; b=c4QCFd4AieTl5bTes/UPb7XMw6X9yKnGhJF7/LL4mYvua7bivbFu9zGzGTnVJUJZqr bsbaJRG/CpU4xwl4U8fBzuUIR5vrCO2ir7OdEbuzIypZT+scK8ilCnonLHQxWY5g4YmA owQPemNL39Yz2E9SmqL9tKjCf+Ze4DRMYo4PqyqNdgyH8ILBsbaMZb5chhxUU4rmoVQO qDwRtER+GWN0b6afoGUxVImK2AvXQ0R3xI08f/9bzvOmG1McTw6y8eDQatEj9P3DJQ6+ prHV8TVg3Z/SyIltd8pfpqJ/eZIUczHb735xmwq0a+7vZSyNSGCOC5wD6oco8hXgMCJ1 D0bQ== X-Gm-Message-State: AOAM532BdB5UkI7IRq+IXW1L9eNOVH/6tWRuxxKMxT0KX5glzqP4zGDx ytlkEgB4hKLtjHhzvohPnD2cBTFfvA6BaoVA2sYzzA== X-Google-Smtp-Source: ABdhPJxm7S3SClIEa8haA53EXImHfLz3JMEYEe8msGZU8hfARA1ModSqS3yvwbR7bVZo3++1HOICb7iJilLXPpaj5No= X-Received: by 2002:aa7:c857:: with SMTP id g23mr3691868edt.100.1623317368085; Thu, 10 Jun 2021 02:29:28 -0700 (PDT) MIME-Version: 1.0 References: <20210607165821.9892-1-peter.maydell@linaro.org> <20210607165821.9892-4-peter.maydell@linaro.org> <23ec05cc-55d3-f343-d834-aa40f7685b37@linaro.org> In-Reply-To: <23ec05cc-55d3-f343-d834-aa40f7685b37@linaro.org> From: Peter Maydell Date: Thu, 10 Jun 2021 10:28:54 +0100 Message-ID: Subject: Re: [PATCH 03/55] target/arm: Handle VPR semantics in existing code To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 7 Jun 2021 at 22:19, Richard Henderson wrote: > > On 6/7/21 9:57 AM, Peter Maydell wrote: > > @@ -410,16 +415,19 @@ void HELPER(v7m_preserve_fp_state)(CPUARMState *env) > > env->v7m.fpccr[is_secure] &= ~R_V7M_FPCCR_LSPACT_MASK; > > > > if (ts) { > > - /* Clear s0 to s31 and the FPSCR */ > > + /* Clear s0 to s31 and the FPSCR and VPR */ > > int i; > > > > for (i = 0; i < 32; i += 2) { > > *aa32_vfp_dreg(env, i / 2) = 0; > > } > > vfp_set_fpscr(env, 0); > > + if (cpu_isar_feature(aa32_mve, cpu)) { > > + env->v7m.vpr = 0; > > + } > > If the vpr does not exist without mve, is it cleaner to simply set vpr > unconditionally? I thought about that, but in the end went for the condition, just to preserve the parallelism with the places where we do need the condition. There didn't seem to me to be much in it. -- PMM