From: Peter Maydell <peter.maydell@linaro.org>
To: Song Gao <gaosong@loongson.cn>
Cc: mjt@tls.msk.ru, qemu-devel@nongnu.org, qemu-stable@nongnu.org,
richard.henderson@linaro.org, zhaotianrui@loongson.cn
Subject: Re: [PATCH v2] hw/loongarch/virt: Fix memory leak
Date: Wed, 8 May 2024 14:02:46 +0100 [thread overview]
Message-ID: <CAFEAcA92bwWvf8NiOtM4M=gDZ0NbsewhsPo1+UMQHM=dnhxDKw@mail.gmail.com> (raw)
In-Reply-To: <20240508023031.3127531-1-gaosong@loongson.cn>
On Wed, 8 May 2024 at 03:30, Song Gao <gaosong@loongson.cn> wrote:
>
> The char pointer 'ramName' point to a block of memory, but never free it.
> Use a small fixed-size buffer for 'ramName'.
>
> Resolves: Coverity CID 1544773
>
> Fixes: 0cf1478d6 ("hw/loongarch: Add numa support")
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> v2:
> - Use a small fixed-size buffer for 'ramName'.
> - Link to V1: https://patchew.org/QEMU/20240507022239.3113987-1-gaosong@loongson.cn/
>
> hw/loongarch/virt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> index c0999878df..ee690ad981 100644
> --- a/hw/loongarch/virt.c
> +++ b/hw/loongarch/virt.c
> @@ -887,7 +887,7 @@ static void loongarch_init(MachineState *machine)
> const CPUArchIdList *possible_cpus;
> MachineClass *mc = MACHINE_GET_CLASS(machine);
> CPUState *cpu;
> - char *ramName = NULL;
> + char ramName[32];
Please don't use fixed-size char arrays for writing strings like this.
> if (!cpu_model) {
> cpu_model = LOONGARCH_CPU_TYPE_NAME("la464");
> @@ -946,7 +946,7 @@ static void loongarch_init(MachineState *machine)
>
> for (i = 1; i < nb_numa_nodes; i++) {
> MemoryRegion *nodemem = g_new(MemoryRegion, 1);
> - ramName = g_strdup_printf("loongarch.node%d.ram", i);
> + sprintf(ramName, "loongarch.node%d.ram", i);
The nicest way to fix this is to use the g_autofree mechanism
so the memory is automatically freed at the end of the block:
g_autofree char *ramName = g_strdup_printf(...);
> memory_region_init_alias(nodemem, NULL, ramName, machine->ram,
> offset, numa_info[i].node_mem);
> memory_region_add_subregion(address_space_mem, phyAddr, nodemem);
thanks
-- PMM
prev parent reply other threads:[~2024-05-08 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 2:30 [PATCH v2] hw/loongarch/virt: Fix memory leak Song Gao
2024-05-08 13:02 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA92bwWvf8NiOtM4M=gDZ0NbsewhsPo1+UMQHM=dnhxDKw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=gaosong@loongson.cn \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).