From: Sam Li <faithilikerun@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Dmitry Fomichev <dmitry.fomichev@wdc.com>
Subject: Re: [PULL v2 10/16] block: introduce zone append write for zoned devices
Date: Sat, 3 Jun 2023 02:03:30 +0800 [thread overview]
Message-ID: <CAAAx-8LneVxfD1onK076-n5B2ZfVveQoiKtRDr-h+FaF0wwmng@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-2-70rwHCxcQvpE-tZRn4qytBSx4b31ZtFhZ97ZpHZNg@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> 于2023年6月3日周六 01:52写道：
>
> On Fri, 2 Jun 2023 at 18:35, Sam Li <faithilikerun@gmail.com> wrote:
> >
> > Peter Maydell <peter.maydell@linaro.org> 于2023年6月3日周六 01:30写道：
> > >
> > > On Fri, 2 Jun 2023 at 18:23, Sam Li <faithilikerun@gmail.com> wrote:
> > > > Thanks for spotting this. You are right that bs->wps is not checked in
> > > > this code path. I think the get_zones_wp() should handle a NULL
> > > > bs->wps which is the function calling wps directly.
> > > >
> > > > Would you like to submit a patch for this? Or I can do it if you are
> > > > not available.
> > >
> > > I don't know anything about this code, so I'm not really in
> > > a position to write a patch. I'm just passing on the information
> > > from the Coverity scanner -- it scales a lot better that way
> > > than trying to write fixes for everything myself :-)
> >
> > I see. I'll fix it. Wish I had known more about this tool when I was
> > testing this code.
>
> Coverity is a bit awkward because the free online scanner only
> runs on code that's already been committed to QEMU, so it doesn't
> tell us about issues until we've already gone through the
> whole code-review-test cycle. Plus it often complains about
> things that aren't bugs, so you have to be a bit cautious
> about interpreting its reports. But it's still a nice tool
> to have.
>
> The online UI is at https://scan.coverity.com/projects/qemu
> and you can create an account and apply for permission to look
> at the recorded defects if you like.
Good to know. Thanks!
Sam
next prev parent reply other threads:[~2023-06-02 18:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 16:04 [PULL v2 00/16] Block patches Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 01/16] block/block-common: add zoned device structs Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 02/16] block/file-posix: introduce helper functions for sysfs attributes Stefan Hajnoczi
[not found] ` <8b0ced3c-2fb5-2479-fe78-f4956ac037a6@linux.ibm.com>
2023-06-02 18:18 ` Sam Li
2023-06-02 18:41 ` Matthew Rosato
2023-06-02 18:45 ` Sam Li
2023-05-15 16:04 ` [PULL v2 03/16] block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice ioctls Stefan Hajnoczi
2024-05-03 12:33 ` Peter Maydell
2024-05-07 15:09 ` Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 04/16] block/raw-format: add zone operations to pass through requests Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 05/16] block: add zoned BlockDriver check to block layer Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 06/16] iotests: test new zone operations Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 07/16] block: add some trace events for new block layer APIs Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 08/16] docs/zoned-storage: add zoned device documentation Stefan Hajnoczi
2023-05-15 16:04 ` [PULL v2 09/16] file-posix: add tracking of the zone write pointers Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 10/16] block: introduce zone append write for zoned devices Stefan Hajnoczi
2023-06-02 16:51 ` Peter Maydell
2023-06-02 17:23 ` Sam Li
2023-06-02 17:30 ` Peter Maydell
2023-06-02 17:35 ` Sam Li
2023-06-02 17:52 ` Peter Maydell
2023-06-02 18:03 ` Sam Li [this message]
2023-05-15 16:05 ` [PULL v2 11/16] qemu-iotests: test zone append operation Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 12/16] block: add some trace events for zone append Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 13/16] virtio-blk: add zoned storage emulation for zoned devices Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 14/16] block: add accounting for zone append operation Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 15/16] virtio-blk: add some trace events for zoned emulation Stefan Hajnoczi
2023-05-15 16:05 ` [PULL v2 16/16] docs/zoned-storage:add zoned emulation use case Stefan Hajnoczi
2023-05-15 23:37 ` [PULL v2 00/16] Block patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAAx-8LneVxfD1onK076-n5B2ZfVveQoiKtRDr-h+FaF0wwmng@mail.gmail.com \
--to=faithilikerun@gmail.com \
--cc=dmitry.fomichev@wdc.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).