From: Sam Li <faithilikerun@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH] qemu-io: add cvtnum() error handling for zone commands
Date: Tue, 7 May 2024 20:14:25 +0200 [thread overview]
Message-ID: <CAAAx-8JOSj6qqmbqk-gSBi0Ksxa_bJ=rvyM69nb_y1rr4hPpxg@mail.gmail.com> (raw)
In-Reply-To: <20240507180558.377233-1-stefanha@redhat.com>
Stefan Hajnoczi <stefanha@redhat.com> 于2024年5月7日周二 20:06写道：
>
> cvtnum() parses positive int64_t values and returns a negative errno on
> failure. Print errors and return early when cvtnum() fails.
>
> While we're at it, also reject nr_zones values greater or equal to 2^32
> since they cannot be represented.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Cc: Sam Li <faithilikerun@gmail.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-io-cmds.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
Reviewed-by: Sam Li <faithilikerun@gmail.com>
Hi Stefan,
Thank you for fixing that. I've been a little busy with moving house lately :)
Sam
prev parent reply other threads:[~2024-05-07 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 18:05 [PATCH] qemu-io: add cvtnum() error handling for zone commands Stefan Hajnoczi
2024-05-07 18:14 ` Sam Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAAx-8JOSj6qqmbqk-gSBi0Ksxa_bJ=rvyM69nb_y1rr4hPpxg@mail.gmail.com' \
--to=faithilikerun@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).