From: Markus Armbruster <armbru@redhat.com>
To: Saif Abrar <saif.abrar@linux.vnet.ibm.com>
Cc: kbusch@kernel.org, its@irrelevant.dk, foss@defmacro.it,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
npiggin@gmail.com
Subject: Re: [PATCH] hw/nvme: Add CLI options for PCI vendor/device IDs and IEEE-OUI ID
Date: Mon, 13 May 2024 09:23:45 +0200 [thread overview]
Message-ID: <87ttj2b2f2.fsf@pond.sub.org> (raw)
In-Reply-To: <20240509124723.3930-1-saif.abrar@linux.vnet.ibm.com> (Saif Abrar's message of "Thu, 9 May 2024 07:47:23 -0500")
Saif Abrar <saif.abrar@linux.vnet.ibm.com> writes:
> Add CLI options for user specified
> - PCI vendor, device, subsystem vendor and subsystem IDs
> - IEEE-OUI ID
>
> e.g. PCI IDs to be specified as follows:
> -device nvme,id_vendor=0xABCD,id_device=0xA0B0,id_subsys_vendor=0xEF00,id_subsys=0xEF01
>
> IEEE-OUI ID (Identify Controller bytes 75:73) is to be
> specified in LE format.
> (e.g. ieee_oui=0xABCDEF => Byte[73]=0xEF, Byte[74]=0xCD, Byte[75]=0xAB).
>
> Signed-off-by: Saif Abrar <saif.abrar@linux.vnet.ibm.com>
[...]
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 127c3d2383..35aeb48e0b 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
[...]
> @@ -8451,6 +8480,13 @@ static Property nvme_props[] = {
> params.sriov_max_vq_per_vf, 0),
> DEFINE_PROP_BOOL("msix-exclusive-bar", NvmeCtrl, params.msix_exclusive_bar,
> false),
> + DEFINE_PROP_UINT16("id_vendor", NvmeCtrl, params.id_vendor, 0),
> + DEFINE_PROP_UINT16("id_device", NvmeCtrl, params.id_device, 0),
> + DEFINE_PROP_UINT16("id_subsys_vendor", NvmeCtrl,
> + params.id_subsys_vendor, 0),
> + DEFINE_PROP_UINT16("id_subsys", NvmeCtrl, params.id_subsys, 0),
> + DEFINE_PROP("ieee_oui", NvmeCtrl, params.ieee_oui, nvme_prop_ieee,
> + uint32_t),
> DEFINE_PROP_END_OF_LIST(),
> };
You add properties, not CLI options. Properties are accessible via CLI
-device, but also via monitor device_add, qom-set, qom-get.
Please rephrase your commit message like "Add properties for".
prev parent reply other threads:[~2024-05-13 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 12:47 [PATCH] hw/nvme: Add CLI options for PCI vendor/device IDs and IEEE-OUI ID Saif Abrar
2024-05-13 7:23 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttj2b2f2.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=foss@defmacro.it \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=npiggin@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saif.abrar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).