From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4657DC47095 for ; Wed, 9 Jun 2021 10:11:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7A1D61108 for ; Wed, 9 Jun 2021 10:11:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7A1D61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqvBM-0003UC-2k for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 06:11:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqv7k-0005wp-TR for qemu-devel@nongnu.org; Wed, 09 Jun 2021 06:07:48 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:43747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqv7j-00007O-8T for qemu-devel@nongnu.org; Wed, 09 Jun 2021 06:07:48 -0400 Received: by mail-wm1-x330.google.com with SMTP id 3-20020a05600c0243b029019f2f9b2b8aso3814587wmj.2 for ; Wed, 09 Jun 2021 03:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=/KLme25OTTJqqOo6Y5OzBTmwd9nK5suD3WUQbHDAcso=; b=JLAqBxtokleuOcnKEFbHI3bBT1i7y6kTn/ZGLeBzPLaZqcyHvCbdipX4nT7ln3YxBC lRV675Jya0OA9pg/mncjH9EtaPNviVyQaWJYS9ZvfmiOZ8JrKGxzIFDR1ewYyuoa9v6z OB2Abh8ChDFV2NZzqSeK/CgFQe1hpiCsTgO1jBvG+3D3fBJ+heQyUjtNFUR5JQQRJoCG z8k3rWwdjzh17OWYPprePrUB05o5N2woq+XA9yBlv0ok+mgpUx7UJd0Rn/zpGCRs3CB1 rXmaY4lmjSgTPYdKZ+1gv7cvYshTsUAq5z5FhKOLG1x4OSoSITnOiESfW137M4nzX81W kNeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=/KLme25OTTJqqOo6Y5OzBTmwd9nK5suD3WUQbHDAcso=; b=Y+4nLkQmvcasDj5cUHvJDvs9YSGK+854Tdc5OwBwep+19IUHrnoLd/QPsYyve2dwLS DCwhlNi45nTHJCTQ5Ce+cAB8jaWWCYFduHv5jCcmLzjEF7iZFaZLN/rl1x7ory3k2RdA +/5jMyDblB+WVQFnTSgybPX3VcnviLveGjX16FO3t0OfufQoEBnDTCrbntZS2h2BV3Ra KGlGRa492m/Al3AXtoKGcBhkztx4RUW44kVKQzPFPXsV8FoPYCzTkOGF0PzqfbbbrMW1 bzAX7XKa0AOezZYWckw+Wd6I28nQTYAm7pp4RXCq6lHEQD67h1ftXi74Mqh3Ztk+OZ5p 5P9g== X-Gm-Message-State: AOAM530YJ/VUZn4V7V7F3VNYlVPYWX3fTH8NRVSCZjUScotgD9H+PS3Z 1VJeGexsUjvShBRpPtxEvmhQCuXYajqCtg== X-Google-Smtp-Source: ABdhPJy9N8QI7ljqxmP1sDlmDLCLTnB3pFu28xZeyeYMzWfBwoHcCyhoBCRZpg2VpZtxtQ5sNbeZDA== X-Received: by 2002:a1c:23d6:: with SMTP id j205mr9175870wmj.94.1623233265792; Wed, 09 Jun 2021 03:07:45 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p5sm24089873wrd.25.2021.06.09.03.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:07:44 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3B7471FF7E; Wed, 9 Jun 2021 11:07:44 +0100 (BST) References: <20210502231844.1977630-1-richard.henderson@linaro.org> <20210502231844.1977630-21-richard.henderson@linaro.org> User-agent: mu4e 1.5.13; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PATCH v3 20/28] tcg: Move in_code_gen_buffer and tests to region.c Date: Wed, 09 Jun 2021 11:07:37 +0100 In-reply-to: <20210502231844.1977630-21-richard.henderson@linaro.org> Message-ID: <87pmwvjqq7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > Shortly, the full code_gen_buffer will only be visible > to region.c, so move in_code_gen_buffer out-of-line. > > Move the debugging versions of tcg_splitwx_to_{rx,rw} > to region.c as well, so that the compiler gets to see > the implementation of in_code_gen_buffer. > > This leaves exactly one use of in_code_gen_buffer outside > of region.c, in cpu_restore_state. Which, being on the > exception path, is not performance critical. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e