QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, ehabkost@redhat.com, qemu-devel@nongnu.org,
	wainersm@redhat.com, "Niteesh G. S." <niteesh.gs@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: GSoC Intro - TUI interface for QMP
Date: Wed, 9 Jun 2021 13:06:15 -0400	[thread overview]
Message-ID: <879a774d-4aa2-9333-b413-bb59ef035525@redhat.com> (raw)
In-Reply-To: <87sg1rp7yg.fsf@dusky.pond.sub.org>

On 6/9/21 7:56 AM, Markus Armbruster wrote:
>> The client could cache the information. (Against what kind of an
>> identifier? Can QEMU report some kind of token that uniquely
>> identifies its binary or uniquely identifies the set of QAPI commands
>> it supports?)

> I proposed something like it to permit QMP clients cache
> query-qmp-schema output.  Libvirt didn't want it, so it never got beyond
> the idea stage.
> 

What ideas did you have for a cache key? We don't need to uniquely 
identify every instance or even every binary.

I suppose we could use an md5/sha1 checksum of the QMP introspection output?

>> This has the potential to exceed our capacity this summer, but a
>> prototype experiment might be helpful to inform future work anyway.
> Beware of the risk that comes with shiny stretch goals: loss of focus.
> I believe this is actually this GSoC project's main risk.

It is and I agree. I have been pushing Niteesh to complete the simplest 
possible prototype imaginable, but I believe he's identified having help 
text as something he'd really like to see, so I am investigating those 
concerns.

I do not think we'll actually be able to fully implement it start to 
finish, but it may be possible that we can implement a kind of "mockup" 
x-help command that has a few hardcoded things we can use to prototype 
the feature in the TUI.

I will keep scope creep in mind, we will pick and choose our battles. I 
am hell-bent on having *anything* checked into the tree by August, and I 
know that can be a longer process than we expect sometimes. I know this 
means keeping it small.

--js



  reply	other threads:[~2021-06-09 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAN6ztm-J2GoQKkLb=Az0H2Q8UKK4oE3PgXg7g14=T53sQAUyDg@mail.gmail.com>
2021-05-21 19:02 ` Fwd: GSoC Intro - TUI interface for QMP Niteesh G. S.
2021-05-24 13:32   ` Stefan Hajnoczi
2021-05-24 17:34     ` John Snow
2021-06-02 11:08       ` Bruno Piazera Larsen
2021-06-11 14:06       ` Vladimir Sementsov-Ogievskiy via
2021-05-26 15:35     ` Fwd: " Niteesh G. S.
2021-06-01 23:47       ` John Snow
2021-06-08 15:01         ` Markus Armbruster
2021-06-08 15:49           ` John Snow
2021-06-09 11:56             ` Markus Armbruster
2021-06-09 17:06               ` John Snow [this message]
2021-06-10  7:19                 ` Markus Armbruster
2021-06-09 12:07             ` Daniel P. Berrangé
2021-06-10 14:35               ` John Snow
2021-06-09 12:03           ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=879a774d-4aa2-9333-b413-bb59ef035525@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=niteesh.gs@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).