From: Marc Zyngier <maz@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Peter Maydell <peter.maydell@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Andrew Jones <drjones@redhat.com>, Haibo Xu <Haibo.Xu@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
qemu-devel@nongnu.org, Catalin Marinas <catalin.marinas@arm.com>,
Juan Quintela <quintela@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
linux-kernel@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH v14 1/8] arm64: mte: Handle race when synchronising tags
Date: Wed, 09 Jun 2021 12:19:31 +0100 [thread overview]
Message-ID: <874ke7z3ng.wl-maz@kernel.org> (raw)
In-Reply-To: <e65943cb-9643-c973-9626-ebf56723ea14@arm.com>
On Wed, 09 Jun 2021 11:51:34 +0100,
Steven Price <steven.price@arm.com> wrote:
>
> On 09/06/2021 11:30, Marc Zyngier wrote:
> > On Mon, 07 Jun 2021 12:08:09 +0100,
> > Steven Price <steven.price@arm.com> wrote:
> >>
> >> mte_sync_tags() used test_and_set_bit() to set the PG_mte_tagged flag
> >> before restoring/zeroing the MTE tags. However if another thread were to
> >> race and attempt to sync the tags on the same page before the first
> >> thread had completed restoring/zeroing then it would see the flag is
> >> already set and continue without waiting. This would potentially expose
> >> the previous contents of the tags to user space, and cause any updates
> >> that user space makes before the restoring/zeroing has completed to
> >> potentially be lost.
> >>
> >> Since this code is run from atomic contexts we can't just lock the page
> >> during the process. Instead implement a new (global) spinlock to protect
> >> the mte_sync_page_tags() function.
> >>
> >> Fixes: 34bfeea4a9e9 ("arm64: mte: Clear the tags when a page is mapped in user-space with PROT_MTE")
> >> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> >> Signed-off-by: Steven Price <steven.price@arm.com>
> >> ---
> >> arch/arm64/kernel/mte.c | 20 +++++++++++++++++---
> >> 1 file changed, 17 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c
> >> index 125a10e413e9..a3583a7fd400 100644
> >> --- a/arch/arm64/kernel/mte.c
> >> +++ b/arch/arm64/kernel/mte.c
> >> @@ -25,6 +25,7 @@
> >> u64 gcr_kernel_excl __ro_after_init;
> >>
> >> static bool report_fault_once = true;
> >> +static DEFINE_SPINLOCK(tag_sync_lock);
> >>
> >> #ifdef CONFIG_KASAN_HW_TAGS
> >> /* Whether the MTE asynchronous mode is enabled. */
> >> @@ -34,13 +35,22 @@ EXPORT_SYMBOL_GPL(mte_async_mode);
> >>
> >> static void mte_sync_page_tags(struct page *page, pte_t *ptep, bool check_swap)
> >> {
> >> + unsigned long flags;
> >> pte_t old_pte = READ_ONCE(*ptep);
> >>
> >> + spin_lock_irqsave(&tag_sync_lock, flags);
> >
> > having though a bit more about this after an offline discussion with
> > Catalin: why can't this lock be made per mm? We can't really share
> > tags across processes anyway, so this is limited to threads from the
> > same process.
>
> Currently there's nothing stopping processes sharing tags (mmap(...,
> PROT_MTE, MAP_SHARED)) - I agree making use of this is tricky and it
> would have been nice if this had just been prevented from the
> beginning.
I don't think it should be prevented. I think it should be made clear
that it is unreliable and that it will result in tag corruption.
> Given the above, clearly the lock can't be per mm and robust.
I don't think we need to make it robust. The architecture actively
prevents sharing if the tags are also shared, just like we can't
really expect the VMM to share tags with the guest.
> > I'd also like it to be documented that page sharing can only reliably
> > work with tagging if only one of the mappings is using tags.
>
> I'm not entirely clear whether you mean "can only reliably work" to be
> "is practically impossible to coordinate tag values", or whether you are
> proposing to (purposefully) introduce the race with a per-mm lock? (and
> document it).
The latter. You can obviously communicate your tags to another task,
but this should come with attached restrictions (mlock?).
> I guess we could have a per-mm lock and handle the race if user space
> screws up with the outcome being lost tags (double clear).
>
> But it feels to me like it could come back to bite in the future since
> VM_SHARED|VM_MTE will almost always work and I fear someone will start
> using it since it's permitted by the kernel.
I'm really worried that performance is going to suck even on a small
system, and this global lock will be heavily contended, even without
considering KVM.
Catalin, any though?
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-06-09 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 11:08 [PATCH v14 0/8] MTE support for KVM guest Steven Price
2021-06-07 11:08 ` [PATCH v14 1/8] arm64: mte: Handle race when synchronising tags Steven Price
2021-06-09 10:30 ` Marc Zyngier
2021-06-09 10:51 ` Steven Price
2021-06-09 11:19 ` Marc Zyngier [this message]
2021-06-09 17:41 ` Catalin Marinas
2021-06-10 8:05 ` Steven Price
2021-06-10 14:07 ` Catalin Marinas
2021-06-07 11:08 ` [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage() Steven Price
2021-06-07 17:07 ` Catalin Marinas
2021-06-09 8:56 ` Steven Price
2021-06-07 11:08 ` [PATCH v14 3/8] arm64: mte: Sync tags for pages where PTE is untagged Steven Price
2021-06-07 11:08 ` [PATCH v14 4/8] KVM: arm64: Introduce MTE VM feature Steven Price
2021-06-07 11:08 ` [PATCH v14 5/8] KVM: arm64: Save/restore MTE registers Steven Price
2021-06-07 11:08 ` [PATCH v14 6/8] KVM: arm64: Expose KVM_ARM_CAP_MTE Steven Price
2021-06-07 11:08 ` [PATCH v14 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Steven Price
2021-06-07 17:21 ` Catalin Marinas
2021-06-07 11:08 ` [PATCH v14 8/8] KVM: arm64: Document MTE capability and ioctl Steven Price
2021-06-07 17:32 ` Catalin Marinas
2021-06-09 8:56 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ke7z3ng.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=Haibo.Xu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).