From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kkostiuk@redhat.com, QEMU Trivial <qemu-trivial@nongnu.org>,
Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Subject: Re: [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password
Date: Fri, 3 May 2024 19:25:42 +0200 [thread overview]
Message-ID: <7934395b-3e86-4dbd-898f-ff667681c8fe@redhat.com> (raw)
In-Reply-To: <20240503171333.241463-1-pbonzini@redhat.com>
On 03/05/2024 19.13, Paolo Bonzini wrote:
> qga/commands-posix.c does not compile on FreeBSD due to a confusion
> between "chpasswdata" (wrong) and "chpasswddata" (used in the #else
> branch).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qga/commands-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 7a065c4085c..7f05996495a 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2173,7 +2173,7 @@ void qmp_guest_set_user_password(const char *username,
> }
>
> #ifdef __FreeBSD__
> - g_autofree char *chpasswdata = g_strdup(rawpasswddata);
> + g_autofree char *chpasswddata = g_strdup(rawpasswddata);
> const char *crypt_flag = crypted ? "-H" : "-h";
> const char *argv[] = {"pw", "usermod", "-n", username,
> crypt_flag, "0", NULL};
Fixes: 0e5b75a390 ("qga/commands-posix: qmp_guest_set_user_password: use
ga_run_command helper")
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-05-03 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 17:13 [PATCH] qga/commands-posix: fix typo in qmp_guest_set_user_password Paolo Bonzini
2024-05-03 17:25 ` Thomas Huth [this message]
2024-05-03 18:00 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7934395b-3e86-4dbd-898f-ff667681c8fe@redhat.com \
--to=thuth@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=kkostiuk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).