QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: "LIZHAOXIN1 [李照鑫]" <LIZHAOXIN1@kingsoft.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"quintela@redhat.com" <quintela@redhat.com>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>
Cc: "LIZHAOXIN1 [李照鑫]" <LIZHAOXIN1@kingsoft.com>,
	"sunhao2 [孙昊]" <sunhao2@kingsoft.com>,
	"DENGLINWEN [邓林文]" <DENGLINWEN@kingsoft.com>,
	"YANGFENG1 [杨峰]" <YANGFENG1@kingsoft.com>
Subject: [PATCH] migration/rdma: Use huge page register VM memory
Date: Mon, 7 Jun 2021 13:57:02 +0000	[thread overview]
Message-ID: <51819991cecb42f6a619768bc61d0bfd@kingsoft.com> (raw)

When using libvirt for RDMA live migration, if the VM memory is too large,
it will take a lot of time to deregister the VM at the source side, resulting
in a long downtime (VM 64G, deregister vm time is about 400ms).
    
Although the VM's memory uses 2M huge pages, the MLNX driver still uses 4K
pages for pin memory, as well as for unpin. So we use huge pages to skip the
process of pin memory and unpin memory to reduce downtime.
   
The test environment:
kernel: linux-5.12
MLNX: ConnectX-4 LX
libvirt command:
virsh migrate --live --p2p --persistent --copy-storage-inc --listen-address \
0.0.0.0 --rdma-pin-all --migrateuri rdma://192.168.0.2 [VM] qemu+tcp://192.168.0.2/system
    
Signed-off-by: lizhaoxin <lizhaoxin1@kingsoft.com>

diff --git a/migration/rdma.c b/migration/rdma.c
index 1cdb4561f3..9823449297 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1123,13 +1123,26 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
     RDMALocalBlocks *local = &rdma->local_ram_blocks;
 
     for (i = 0; i < local->nb_blocks; i++) {
-        local->block[i].mr =
-            ibv_reg_mr(rdma->pd,
-                    local->block[i].local_host_addr,
-                    local->block[i].length,
-                    IBV_ACCESS_LOCAL_WRITE |
-                    IBV_ACCESS_REMOTE_WRITE
-                    );
+        if (strcmp(local->block[i].block_name,"pc.ram") == 0) {
+            local->block[i].mr =
+                ibv_reg_mr(rdma->pd,
+                        local->block[i].local_host_addr,
+                        local->block[i].length,
+                        IBV_ACCESS_LOCAL_WRITE |
+                        IBV_ACCESS_REMOTE_WRITE |
+                        IBV_ACCESS_ON_DEMAND |
+                        IBV_ACCESS_HUGETLB
+                        );
+        } else {
+            local->block[i].mr =
+                ibv_reg_mr(rdma->pd,
+                        local->block[i].local_host_addr,
+                        local->block[i].length,
+                        IBV_ACCESS_LOCAL_WRITE |
+                        IBV_ACCESS_REMOTE_WRITE
+                        );
+        }
+
         if (!local->block[i].mr) {
             perror("Failed to register local dest ram block!\n");
             break;

             reply	other threads:[~2021-06-07 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 13:57 LIZHAOXIN1 [李照鑫] [this message]
2021-06-07 14:17 ` [PATCH] migration/rdma: Use huge page register VM memory Daniel P. Berrangé
2021-06-07 15:00   ` Dr. David Alan Gilbert
2021-06-10 15:35     ` 回复: " LIZHAOXIN1 [李照鑫]
2021-06-10 15:33   ` LIZHAOXIN1 [李照鑫]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51819991cecb42f6a619768bc61d0bfd@kingsoft.com \
    --to=lizhaoxin1@kingsoft.com \
    --cc=DENGLINWEN@kingsoft.com \
    --cc=YANGFENG1@kingsoft.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=sunhao2@kingsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).