From: Vincent Fu <vincentfu@gmail.com>
To: Klaus Jensen <k.jensen@samsung.com>,
Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>,
Jesper Devantier <foss@defmacro.it>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/nvme: fix mo field in io mgnt send
Date: Wed, 8 May 2024 09:36:39 -0400 [thread overview]
Message-ID: <50c45bde-738e-4c1d-bf1f-5345eff814b2@gmail.com> (raw)
In-Reply-To: <888fce70-768e-474f-8526-fa05b41540c1@gmail.com>
On 5/7/24 10:05, Vincent Fu wrote:
> On 5/6/24 04:06, Klaus Jensen wrote:
>> The Management Operation field of I/O Management Send is only 8 bits,
>> not 16.
>>
>> Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
>> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
>> ---
>> hw/nvme/ctrl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>> index 9e7bbebc8bb0..ede5f281dd7c 100644
>> --- a/hw/nvme/ctrl.c
>> +++ b/hw/nvme/ctrl.c
>> @@ -4387,7 +4387,7 @@ static uint16_t nvme_io_mgmt_send(NvmeCtrl *n,
>> NvmeRequest *req)
>> {
>> NvmeCmd *cmd = &req->cmd;
>> uint32_t cdw10 = le32_to_cpu(cmd->cdw10);
>> - uint8_t mo = (cdw10 & 0xff);
>> + uint8_t mo = cdw10 & 0xf;
>> switch (mo) {
>> case NVME_IOMS_MO_NOP:
>>
>> ---
>> base-commit: 84b0eb1826f690aa8d51984644318ee6c810f5bf
>> change-id: 20240506-fix-ioms-mo-97098c6c5396
>>
>> Best regards,
>
> Reviewed-by: Vincent Fu <vincent.fu@samsung.com>
Klaus, upon taking a second look, the original code is correct. The
proposed change would only keep the least significant 4 bits of the MO
field. The original code gives you the 8 bits needed.
Let me withdraw my Reviewed-by.
Vincent
prev parent reply other threads:[~2024-05-08 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 8:06 [PATCH] hw/nvme: fix mo field in io mgnt send Klaus Jensen
2024-05-07 14:05 ` Vincent Fu
2024-05-08 13:36 ` Vincent Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c45bde-738e-4c1d-bf1f-5345eff814b2@gmail.com \
--to=vincentfu@gmail.com \
--cc=foss@defmacro.it \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).