QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Bibo Mao <maobibo@loongson.cn>, Laurent Vivier <lvivier@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qtest/boot-serial-test: Add support on LoongArch system
Date: Wed, 8 May 2024 11:00:18 +0200	[thread overview]
Message-ID: <4ce31fa5-16b0-491c-9956-35ed68af2a6f@redhat.com> (raw)
In-Reply-To: <20240508085514.2510592-1-maobibo@loongson.cn>

On 08/05/2024 10.55, Bibo Mao wrote:
> Add boot-serial-test test case support on LoongArch system.

... and also the filter tests?

> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   tests/qtest/boot-serial-test.c | 10 ++++++++++
>   tests/qtest/meson.build        |  4 ++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
> index e3b7d65fe5..631015e8c8 100644
> --- a/tests/qtest/boot-serial-test.c
> +++ b/tests/qtest/boot-serial-test.c
> @@ -129,6 +129,14 @@ static const uint8_t kernel_stm32vldiscovery[] = {
>       0x04, 0x38, 0x01, 0x40                  /* 0x40013804 = USART1 TXD */
>   };
>   
> +static const uint8_t bios_loongarch64[] = {
> +    0x0c, 0xc0, 0x3f, 0x14,                 /* lu12i.w $t0, 0x1fe00    */
> +    0x8c, 0x81, 0x87, 0x03,                 /* ori     $t0, $t0, 0x1e0 */
> +    0x0d, 0x50, 0x81, 0x03,                 /* li.w    $t1, 'T'        */
> +    0x8d, 0x01, 0x00, 0x29,                 /* st.b    $t1, $t0, 0     */
> +    0xff, 0xf3, 0xff, 0x53,                 /*  b      -16  # loop     */
> +};
> +
>   typedef struct testdef {
>       const char *arch;       /* Target architecture */
>       const char *machine;    /* Name of the machine */
> @@ -181,6 +189,8 @@ static const testdef_t tests[] = {
>       { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
>       { "arm", "stm32vldiscovery", "", "T",
>         sizeof(kernel_stm32vldiscovery), kernel_stm32vldiscovery },
> +    { "loongarch64", "virt", "-cpu max", "TT", sizeof(bios_loongarch64),
> +      NULL, bios_loongarch64 },
>   
>       { NULL }
>   };
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 6f2f594ace..6619b630e6 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -256,6 +256,10 @@ qtests_s390x = \
>   qtests_riscv32 = \
>     (config_all_devices.has_key('CONFIG_SIFIVE_E_AON') ? ['sifive-e-aon-watchdog-test'] : [])
>   
> + qtests_loongarch64 = \
> +  qtests_filter + \
> +  ['boot-serial-test']

It's already a little bit messed up, but I think we originally had the 
entries in alphabetical order, so I'd like to suggest to add this between 
qtests_hppa and qtests_m68k instead.

  Thomas


>   qos_test_ss = ss.source_set()
>   qos_test_ss.add(
>     'ac97-test.c',
> 
> base-commit: 4e66a08546a2588a4667766a1edab9caccf24ce3



  reply	other threads:[~2024-05-08  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  8:55 [PATCH] tests/qtest/boot-serial-test: Add support on LoongArch system Bibo Mao
2024-05-08  9:00 ` Thomas Huth [this message]
2024-05-08  9:17   ` maobibo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ce31fa5-16b0-491c-9956-35ed68af2a6f@redhat.com \
    --to=thuth@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=maobibo@loongson.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).