From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH] hw/mips/loongson3_virt: Emulate suspend function
Date: Wed, 8 May 2024 18:48:23 +0200 [thread overview]
Message-ID: <37a227ca-af03-4f03-b135-b12ea2ef521a@linaro.org> (raw)
In-Reply-To: <30ac6d1d-6bda-473b-b212-25443efcde03@linaro.org>
On 8/5/24 17:35, Philippe Mathieu-Daudé wrote:
> On 8/5/24 11:31, Jiaxun Yang wrote:
>> Suspend function is emulated as what hardware actually do.
>> Doorbell register fields are updates to include suspend value,
>> suspend vector is encoded in firmware blob and fw_cfg is updated
>> to include S3 bits as what x86 did.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> hw/mips/loongson3_bootp.c | 1 +
>> hw/mips/loongson3_virt.c | 19 +++++++++++++++++++
>> 2 files changed, 20 insertions(+)
>
> Thanks, patch queued.
Fixed:
ERROR: use g_memdup2() instead of unsafe g_memdup()
#76: FILE: hw/mips/loongson3_virt.c:293:
+ fw_cfg_add_file(fw_cfg, "etc/system-states", g_memdup(suspend, 6), 6);
next prev parent reply other threads:[~2024-05-08 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:31 [PATCH] hw/mips/loongson3_virt: Emulate suspend function Jiaxun Yang
2024-05-08 15:35 ` Philippe Mathieu-Daudé
2024-05-08 16:48 ` Philippe Mathieu-Daudé [this message]
2024-05-08 17:28 ` Jiaxun Yang
2024-05-08 21:54 ` Philippe Mathieu-Daudé
2024-05-08 21:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a227ca-af03-4f03-b135-b12ea2ef521a@linaro.org \
--to=philmd@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).