From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC04C47094 for ; Thu, 10 Jun 2021 12:58:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C77D4613DE for ; Thu, 10 Jun 2021 12:58:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C77D4613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrKGo-0003w6-NY for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 08:58:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKFv-00032d-1h for qemu-devel@nongnu.org; Thu, 10 Jun 2021 08:57:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrKFp-0005fA-Ar for qemu-devel@nongnu.org; Thu, 10 Jun 2021 08:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623329868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7uO+yjB4tmmOkGTqndziqcY4ITxHtZU46eCT9vUI7VA=; b=Pus0jkxcjCyr+Bq6L5HGSD+9RmW8cVRak+DiZ0x5DtsGgpdK3oS9GN5LPPu/62oUu/Olr5 nouNcQedZunGJWIdAoaLzvO+Ne8eUcUZiEm6bkxp0aHhOYljxwcFaojxv6s6wz2JeTMcaD EeZnfLGgDsd4EsJBwbL2Eu98E2Zv/wc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-KlURnEO5N1CRk2-uYucLng-1; Thu, 10 Jun 2021 08:57:45 -0400 X-MC-Unique: KlURnEO5N1CRk2-uYucLng-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6AEC51940949; Thu, 10 Jun 2021 12:57:40 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A881F19C45; Thu, 10 Jun 2021 12:57:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3627818000B2; Thu, 10 Jun 2021 14:57:21 +0200 (CEST) Date: Thu, 10 Jun 2021 14:57:21 +0200 From: Gerd Hoffmann To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH v2 17/18] modules: check arch and block load on mismatch Message-ID: <20210610125721.b27j6raf4h3qujt3@sirius.home.kraxel.org> References: <20210610055755.538119-1-kraxel@redhat.com> <20210610055755.538119-18-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Michael Roth , Cornelia Huck , Peter Lieven , qemu-devel@nongnu.org, Max Reitz , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Ronnie Sahlberg , Samuel Thibault , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , David Hildenbrand , Richard Henderson , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > > for (modlist = modinfo->list; modlist != NULL; modlist = modlist->next) { > > + if (modlist->value->has_arch) { > > + if (strcmp(modlist->value->name, module_name) == 0) { > > + if (!module_arch || > > + strcmp(modlist->value->arch, module_arch) != 0) { > > + return false; > > + } > > + } > > + } > > I have a little hard time following the code paths, but IIUC, with this > change, instead of "module.so" we would have multiple copies of something > like "module-$arch.so" ? Not yet with this series, but easily doable on top of this (see other patch series sent today). > Then we load them all, read their modinfo section > and discard the ones with non-matching arch ? No. There is a utility reading the modinfo section (patch #2), write out the info as json (patch #2 has the schema), then qemu will read that json file (patch #13) ... > for arch specific modules. That would let us load only the modules we know > are applicable for the system target arch and not need this post-load > filtering from metadata. ... so it's pre-load filtering, not post-load. take care, Gerd