From: Stefano Garzarella <sgarzare@redhat.com>
To: Jiang Wang <jiang.wang@bytedance.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com
Subject: Re: [RFC v1] virtio/vsock: add two more queues for datagram types
Date: Thu, 10 Jun 2021 11:40:39 +0200 [thread overview]
Message-ID: <20210610094039.2ek3som6fxcgjtyw@steredhat> (raw)
In-Reply-To: <20210610001424.209158-1-jiang.wang@bytedance.com>
On Thu, Jun 10, 2021 at 12:14:24AM +0000, Jiang Wang wrote:
>Datagram sockets are connectionless and unreliable.
>The sender does not know the capacity of the receiver
>and may send more packets than the receiver can handle.
>
>Add two more dedicate virtqueues for datagram sockets,
>so that it will not unfairly steal resources from
>stream and future connection-oriented sockets.
>
>The virtio spec patch is here:
>https://www.spinics.net/lists/linux-virtualization/msg50027.html
>
>Here is the link for the linux kernel git repo with patches
>to support dgram sockets:
>https://github.com/Jiang1155/linux/tree/vsock-dgram-v1
>
>Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
>---
> configure | 13 +++++++++++++
> hw/virtio/vhost-vsock-common.c | 11 ++++++++++-
> hw/virtio/vhost-vsock.c | 8 +++++---
> include/hw/virtio/vhost-vsock-common.h | 10 +++++++++-
> include/standard-headers/linux/virtio_vsock.h | 3 +++
> meson.build | 1 +
> 6 files changed, 41 insertions(+), 5 deletions(-)
>
>diff --git a/configure b/configure
>index 9f016b06b5..6455b283a5 100755
>--- a/configure
>+++ b/configure
>@@ -343,6 +343,7 @@ vhost_net="$default_feature"
> vhost_crypto="$default_feature"
> vhost_scsi="$default_feature"
> vhost_vsock="$default_feature"
>+vhost_vsock_dgram="no"
> vhost_user="no"
> vhost_user_blk_server="auto"
> vhost_user_fs="$default_feature"
>@@ -1272,6 +1273,10 @@ for opt do
> ;;
> --enable-vhost-vsock) vhost_vsock="yes"
> ;;
>+ --disable-vhost-vsock-dgram) vhost_vsock_dgram="no"
>+ ;;
>+ --enable-vhost-vsock-dgram) vhost_vsock_dgram="yes"
>+ ;;
I don't think we should add a configuration option to enable/disable the
dgram support at build time.
I think we should do it at runtime looking at the features negiotated.
Take a look at virtio_net_set_multiqueue().
Thanks,
Stefano
next prev parent reply other threads:[~2021-06-10 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 0:14 [RFC v1] virtio/vsock: add two more queues for datagram types Jiang Wang
2021-06-10 9:40 ` Stefano Garzarella [this message]
2021-06-10 17:29 ` Jiang Wang .
2021-06-24 6:50 ` Jiang Wang .
2021-06-24 14:31 ` Stefano Garzarella
2021-06-30 22:44 ` [External] " Jiang Wang .
2021-07-01 6:55 ` Stefano Garzarella
2021-07-01 22:09 ` Jiang Wang .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610094039.2ek3som6fxcgjtyw@steredhat \
--to=sgarzare@redhat.com \
--cc=jiang.wang@bytedance.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).