QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] don't require a disk image for network boot
       [not found] <87bqjyxg10.fsf@tac.ki.iif.hu>
@ 2007-02-13 14:58 ` andrzej zaborowski
  2007-02-13 15:08   ` Stuart Brady
  2007-02-15  9:17   ` Thomas Petazzoni
  0 siblings, 2 replies; 6+ messages in thread
From: andrzej zaborowski @ 2007-02-13 14:58 UTC (permalink / raw
  To: qemu-devel

---------- Forwarded message ----------
From: Ferenc Wagner <wferi@niif.hu>
To: qemu-devel@nongnu.org
Date: Thu, 08 Feb 2007 18:02:23 +0100
Subject: don't require a disk image for network boot
Hi,

What do you think about the following patch?  As a side note, I'd
really prefer option roms with serial output enabled (check
CONSOLE_DUAL on rom-o-matic).  Maybe even uncheck ASK_BOOT...  Hmm,
maybe that's already done, I couldn't see... :)

Anyway, thanks for the nice work!

Regards,
Feri.
(please Cc: me, I'm not subscribed)


diff -Nru qemu-0.9.0/vl.c qemu/vl.c
--- qemu-0.9.0/vl.c     2007-02-06 00:01:54.000000000 +0100
+++ qemu/vl.c   2007-02-08 17:54:00.723622909 +0100
@@ -7017,6 +7017,7 @@
     linux_boot = (kernel_filename != NULL);

     if (!linux_boot &&
+        boot_device != 'n' &&
         hd_filename[0] == '\0' &&
         (cdrom_index >= 0 && hd_filename[cdrom_index] == '\0') &&
         fd_filename[0] == '\0')

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] don't require a disk image for network boot
  2007-02-13 14:58 ` [Qemu-devel] [PATCH] don't require a disk image for network boot andrzej zaborowski
@ 2007-02-13 15:08   ` Stuart Brady
  2007-02-15  9:17   ` Thomas Petazzoni
  1 sibling, 0 replies; 6+ messages in thread
From: Stuart Brady @ 2007-02-13 15:08 UTC (permalink / raw
  To: qemu-devel; +Cc: Ferenc Wagner

On Tue, Feb 13, 2007 at 03:58:13PM +0100, andrzej zaborowski wrote:
> What do you think about the following patch?  As a side note, I'd
> really prefer option roms with serial output enabled (check
> CONSOLE_DUAL on rom-o-matic).  Maybe even uncheck ASK_BOOT...  Hmm,
> maybe that's already done, I couldn't see... :)

As requested, here's the diff with the correct formatting:

diff -Nru qemu-0.9.0/vl.c qemu/vl.c
--- qemu-0.9.0/vl.c     2007-02-06 00:01:54.000000000 +0100
+++ qemu/vl.c   2007-02-08 17:54:00.723622909 +0100
@@ -7017,6 +7017,7 @@
     linux_boot = (kernel_filename != NULL);
 
     if (!linux_boot &&
+        boot_device != 'n' &&
         hd_filename[0] == '\0' && 
         (cdrom_index >= 0 && hd_filename[cdrom_index] == '\0') &&
         fd_filename[0] == '\0')

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] don't require a disk image for network boot
  2007-02-13 14:58 ` [Qemu-devel] [PATCH] don't require a disk image for network boot andrzej zaborowski
  2007-02-13 15:08   ` Stuart Brady
@ 2007-02-15  9:17   ` Thomas Petazzoni
  2007-02-15 15:45     ` Ed Swierk
  2007-02-15 16:27     ` Paul Brook
  1 sibling, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2007-02-15  9:17 UTC (permalink / raw
  To: qemu-devel

Hi,

Le Tue, 13 Feb 2007 15:58:13 +0100,
"andrzej zaborowski" <balrog@zabor.org> a écrit :

> Subject: don't require a disk image for network boot

BTW, is there a reason why a disk image is required when using the
-kernel option ?

In the following case: -kernel vmlinuz -append "nfsroot=blabla", we
could boot over the network, without the need for any disk image, but
Qemu wants to have a disk image. Is it mandatory ?

Thanks,

Thomas
-- 
Thomas Petazzoni - thomas.petazzoni@enix.org
http://{thomas,sos,kos}.enix.org - http://www.toulibre.org
http://www.{livret,agenda}dulibre.org

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] don't require a disk image for network boot
  2007-02-15  9:17   ` Thomas Petazzoni
@ 2007-02-15 15:45     ` Ed Swierk
  2007-02-15 16:27     ` Paul Brook
  1 sibling, 0 replies; 6+ messages in thread
From: Ed Swierk @ 2007-02-15 15:45 UTC (permalink / raw
  To: qemu-devel

On 2/15/07, Thomas Petazzoni <thomas.petazzoni@enix.org> wrote:
> BTW, is there a reason why a disk image is required when using the
> -kernel option ?
>
> In the following case: -kernel vmlinuz -append "nfsroot=blabla", we
> could boot over the network, without the need for any disk image, but
> Qemu wants to have a disk image. Is it mandatory ?

On Linux, -hda /dev/zero works fine, so I'd say there's no reason a
disk image is necessary.

--Ed

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] don't require a disk image for network boot
  2007-02-15  9:17   ` Thomas Petazzoni
  2007-02-15 15:45     ` Ed Swierk
@ 2007-02-15 16:27     ` Paul Brook
  2007-02-17  0:57       ` Rob Landley
  1 sibling, 1 reply; 6+ messages in thread
From: Paul Brook @ 2007-02-15 16:27 UTC (permalink / raw
  To: qemu-devel

On Thursday 15 February 2007 09:17, Thomas Petazzoni wrote:
> Hi,
>
> Le Tue, 13 Feb 2007 15:58:13 +0100,
>
> "andrzej zaborowski" <balrog@zabor.org> a écrit :
> > Subject: don't require a disk image for network boot
>
> BTW, is there a reason why a disk image is required when using the
> -kernel option ?
>
> In the following case: -kernel vmlinuz -append "nfsroot=blabla", we
> could boot over the network, without the need for any disk image, but
> Qemu wants to have a disk image. Is it mandatory ?

The BIOS doesn't know about the -kernel option, so qemu replaces the first 
sector of the disk image with a dummy bootloader that jumps to the preloaded 
kernel. It can only do that if there is an image to replace.

Paul

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] don't require a disk image for network boot
  2007-02-15 16:27     ` Paul Brook
@ 2007-02-17  0:57       ` Rob Landley
  0 siblings, 0 replies; 6+ messages in thread
From: Rob Landley @ 2007-02-17  0:57 UTC (permalink / raw
  To: qemu-devel; +Cc: Paul Brook

On Thursday 15 February 2007 11:27 am, Paul Brook wrote:
> On Thursday 15 February 2007 09:17, Thomas Petazzoni wrote:
> > Hi,
> >
> > Le Tue, 13 Feb 2007 15:58:13 +0100,
> >
> > "andrzej zaborowski" <balrog@zabor.org> a écrit :
> > > Subject: don't require a disk image for network boot
> >
> > BTW, is there a reason why a disk image is required when using the
> > -kernel option ?
> >
> > In the following case: -kernel vmlinuz -append "nfsroot=blabla", we
> > could boot over the network, without the need for any disk image, but
> > Qemu wants to have a disk image. Is it mandatory ?
> 
> The BIOS doesn't know about the -kernel option, so qemu replaces the first 
> sector of the disk image with a dummy bootloader that jumps to the preloaded 
> kernel. It can only do that if there is an image to replace.

Yeah, but on Linux the standard workaround is to supply -hda /dev/zero, and if 
qemu notices that it has -kernel but no hda, from a UI perspective qemu could 
easily supply the standard workaround for itself...

Rob
-- 
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2007-02-17  0:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87bqjyxg10.fsf@tac.ki.iif.hu>
2007-02-13 14:58 ` [Qemu-devel] [PATCH] don't require a disk image for network boot andrzej zaborowski
2007-02-13 15:08   ` Stuart Brady
2007-02-15  9:17   ` Thomas Petazzoni
2007-02-15 15:45     ` Ed Swierk
2007-02-15 16:27     ` Paul Brook
2007-02-17  0:57       ` Rob Landley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).