From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Kostiantyn Kostiuk <konstantin@daynix.com>, qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] qga-win: Free GMatchInfo properly
Date: Thu, 10 Jun 2021 18:04:35 +0200 [thread overview]
Message-ID: <1c458f41-4fdd-5643-ba02-e3836e722aa3@redhat.com> (raw)
In-Reply-To: <20210610155811.3313927-1-konstantin@daynix.com>
On 6/10/21 5:58 PM, Kostiantyn Kostiuk wrote:
> The g_regex_match function creates match_info even if it
> returns FALSE. So we should always call g_match_info_free.
> A better solution is using g_autoptr for match_info variable.
>
> Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
> ---
> qga/commands-win32.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2021-06-10 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 15:58 [PATCH v2] qga-win: Free GMatchInfo properly Kostiantyn Kostiuk
2021-06-10 16:02 ` Daniel P. Berrangé
2021-06-10 16:08 ` Konstantin Kostiuk
2021-06-10 16:14 ` Daniel P. Berrangé
2021-07-14 7:26 ` Konstantin Kostiuk
2021-07-28 7:54 ` Konstantin Kostiuk
2021-07-28 11:58 ` [PATCH-for-6.1 " Philippe Mathieu-Daudé
2021-06-10 16:04 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c458f41-4fdd-5643-ba02-e3836e722aa3@redhat.com \
--to=philmd@redhat.com \
--cc=konstantin@daynix.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).