From: no-reply@patchew.org
To: jakub.jermar@kernkonzept.com
Cc: jakub.jermar@kernkonzept.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/nvme: be more careful when deasserting IRQs
Date: Mon, 14 Jun 2021 15:39:24 -0700 (PDT) [thread overview]
Message-ID: <162371036293.2358.8579859643092269612@7c66fb7bc3ab> (raw)
In-Reply-To: <20210610114624.304681-1-jakub.jermar@kernkonzept.com>
Patchew URL: https://patchew.org/QEMU/20210610114624.304681-1-jakub.jermar@kernkonzept.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210610114624.304681-1-jakub.jermar@kernkonzept.com
Subject: [PATCH] hw/nvme: be more careful when deasserting IRQs
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210610132505.5827-1-peter.maydell@linaro.org -> patchew/20210610132505.5827-1-peter.maydell@linaro.org
* [new tag] patchew/20210614135429.56475-1-jakub.jermar@kernkonzept.com -> patchew/20210614135429.56475-1-jakub.jermar@kernkonzept.com
Switched to a new branch 'test'
aacc285 hw/nvme: be more careful when deasserting IRQs
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/nvme/ctrl.c:485:
+ if (q && q->vector == cq->vector && q->head != q->tail)
[...]
total: 1 errors, 0 warnings, 39 lines checked
Commit aacc285402f0 (hw/nvme: be more careful when deasserting IRQs) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210610114624.304681-1-jakub.jermar@kernkonzept.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2021-06-14 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:46 [PATCH] hw/nvme: be more careful when deasserting IRQs Jakub Jermář
2021-06-10 17:33 ` Klaus Jensen
2021-06-10 18:14 ` Klaus Jensen
2021-06-14 13:52 ` Jakub Jermář
2021-06-14 22:39 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162371036293.2358.8579859643092269612@7c66fb7bc3ab \
--to=no-reply@patchew.org \
--cc=jakub.jermar@kernkonzept.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).