From: Lucas Mateus Martins Araujo e Castro <lucas.araujo@eldorado.org.br>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org, luis.pires@eldorado.org.br,
fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org,
matheus.ferst@eldorado.org.br
Subject: Re: [PATCH v2 2/3] target/ppc: divided mmu_helper.c in 2 files
Date: Tue, 15 Jun 2021 15:44:33 -0300 [thread overview]
Message-ID: <13694281-b11c-4617-4a43-507395d8076f@eldorado.org.br> (raw)
In-Reply-To: <YMg9qx4ddgDchtgS@yekko>
[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]
On 15/06/2021 02:42, David Gibson wrote:
> On Thu, Jun 10, 2021 at 01:46:47PM -0300, Lucas Mateus Castro (alqotel) wrote:
>> Moved functions in mmu_helper.c that should be compiled in build to
> "should be compiled in build" is not very clear to me. What's the
> distinction between both the files.
Looking back now the description is really confusing, so let me rephrase
that: mmu_helper.c is being split in 2 files, mmu_helper.c (which
contains TCG-only code) and mmu_common.c (which contains code needed in
!TCG)
>> mmu_common.c, moved declaration of functions that both files use to
>> cpu.h and moved struct declarations and inline functions needed by
>> both to target/ppc/internal.h. Updated meson.build to compile the
>> new file. ppc6xx_tlb_getnum is not an inline function anymore.
> Overall this looks reasonable. I think there's quite a lot you put
> into mmu_common.c that can TCG-only, but it's reasonable to delay the
> cleanups that will allow that to happen until further down the track.
For this patch I've put the helpers and static functions only called by
them in mmu_helper.c and other functions in mmu_common.c, but looking
now there's some more code motion I could add to this patch series, so
I'll add them to the end of the patch series to not interfere with the
previews patches.
--
Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
<https://www.eldorado.org.br/?utm_campaign=assinatura_de_e-mail&utm_medium=email&utm_source=RD+Station>
Departamento Computação Embarcada
Estagiario
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
[-- Attachment #2: Type: text/html, Size: 2530 bytes --]
next prev parent reply other threads:[~2021-06-15 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 16:46 [PATCH v2 0/3] target/ppc: mmu cleanup Lucas Mateus Castro (alqotel)
2021-06-10 16:46 ` [PATCH v2 1/3] target/ppc: Turn ppc_tlb_invalid_all in a noop Lucas Mateus Castro (alqotel)
2021-06-10 17:07 ` Bruno Piazera Larsen
2021-06-15 5:38 ` David Gibson
2021-06-15 16:24 ` Lucas Mateus Martins Araujo e Castro
2021-06-10 16:46 ` [PATCH v2 2/3] target/ppc: divided mmu_helper.c in 2 files Lucas Mateus Castro (alqotel)
2021-06-15 5:42 ` David Gibson
2021-06-15 18:44 ` Lucas Mateus Martins Araujo e Castro [this message]
2021-06-10 16:46 ` [PATCH v2 3/3] target/ppc: moved ppc_store_sdr1 to mmu_common.c Lucas Mateus Castro (alqotel)
2021-06-10 16:54 ` Bruno Piazera Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13694281-b11c-4617-4a43-507395d8076f@eldorado.org.br \
--to=lucas.araujo@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=fernando.valle@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).