From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A074BC47094 for ; Thu, 10 Jun 2021 14:15:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A81D613D9 for ; Thu, 10 Jun 2021 14:15:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A81D613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrLTO-0001BS-JG for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 10:15:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrLSC-00086b-EM for qemu-devel@nongnu.org; Thu, 10 Jun 2021 10:14:40 -0400 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:38507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrLSA-0005GQ-PX for qemu-devel@nongnu.org; Thu, 10 Jun 2021 10:14:40 -0400 Received: by mail-pj1-x102b.google.com with SMTP id m13-20020a17090b068db02901656cc93a75so3821105pjz.3 for ; Thu, 10 Jun 2021 07:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=lNGtWk5iSTlEnwB7FJ7KrxxwtJSSeS2pIKYxzXJ8bc0=; b=MIdpE0p220gxAjjtwcJ1o05bMO8/W3tVWdbbrmor9p2iiQXG5QHKmWXwX3lIMk5X2D 26I2VCDj39bLxC83VhpcEbSW3g+vBHEIW/f94NEFhsxunSgq4E6B6QK+JHnJECVoZAl1 ktu6pzPwp5MSVyByIp4NX6x7CAh0F0XwzPqBtBXrQYI1ZRh81YoXm23a1/L+9muzlPy6 mUTXiSpKQp3seUM/wRYCgd4Ehcwt8/zJemP3TwDZktsG/GdmIutbBDtLbZS1Kw7txQ8v jtyOzaPDyy1cOkTK/NBdVNDXJiH2f9yRKrO7y/cHsKyQHIbiqXTRgoMcSBjksc9Z3kL/ 764Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lNGtWk5iSTlEnwB7FJ7KrxxwtJSSeS2pIKYxzXJ8bc0=; b=LTTTLXqFT05SJjvEFcKK8p3HMW6aqJ1/FdV/1O+TGCDs2LNIJ5fOBzvVJokLjX7Boo 76EY9Gjc/THQZgyphKLjRdp+nFl7W2iQOVjyKUXJElq5I6G+PUigoUkZoBtfwJbATAzD Yx60W0UDqyf4jZFefKLYew6Av097iYPO58vZ8HeSL13sl33wD+/dpbkQ7Ly8QSk3qKzH 4d3lceaB2G7mAXtQDYZBYyANc5TF1K+2TRm/E+1lh4llXVcX3yJ5TIAVxsBhJaCAPd03 TLbNLkv8LBt5VjU/2rqDSB8e73TTS+6Dwg3oTmV/BmrxpyDZpMIRRTW1uW8grRvFFLyI AX6w== X-Gm-Message-State: AOAM5300QtKmEqbBn6PSwqKVZZWs7yaGGz950YXSwhcNLHylenAc0UwJ 6YBDAUvdNOSAv5th70ptZBq9j0GQnF6m7w== X-Google-Smtp-Source: ABdhPJxvKMF7RNXOBB1aWmay45ErQQzDlDy3ppmgsLA0V1GfIfAIk9+f5U3RWpzlMQ13/1Rv+8PHSw== X-Received: by 2002:a17:902:c951:b029:106:513f:58ff with SMTP id i17-20020a170902c951b0290106513f58ffmr5116650pla.37.1623334477125; Thu, 10 Jun 2021 07:14:37 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id c3sm2636861pfl.42.2021.06.10.07.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 07:14:36 -0700 (PDT) Subject: Re: [PATCH 55/55] target/arm: Make VMOV scalar <-> gpreg beatwise for MVE To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210607165821.9892-1-peter.maydell@linaro.org> <20210607165821.9892-56-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <12ecc670-c726-75d4-7bf3-29ea705a7626@linaro.org> Date: Thu, 10 Jun 2021 07:14:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210607165821.9892-56-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/7/21 9:58 AM, Peter Maydell wrote: > + if (dc_isar_feature(aa32_mve, s)) { > + TCGv_i32 eci; > + > + mve_update_eci(s); > + eci = tcg_const_i32(s->eci << 4); > + store_cpu_field(eci, condexec_bits); > + } I think it would be handy to package this up into an mve_update_and_store_eci function. There are 3 copies, including the previous in VPST. Otherwise, Reviewed-by: Richard Henderson r~