From: Bernhard Beschow <shentey@gmail.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael Roth" <michael.roth@amd.com>
Subject: Re: [PATCH v3 0/6] X86: Alias isa-bios area and clean up
Date: Tue, 14 May 2024 08:31:28 +0000 [thread overview]
Message-ID: <0F5CD4D8-4942-4E6C-A88D-EB715CAC2553@gmail.com> (raw)
In-Reply-To: <bf76c488-c454-e893-89f5-94e78a8d0329@eik.bme.hu>
Am 8. Mai 2024 20:39:28 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
>On Wed, 8 May 2024, Bernhard Beschow wrote:
>> This series changes the "isa-bios" MemoryRegion to be an alias rather than a
>> copy in the pflash case. This fixes issuing pflash commands in the isa-bios
>> region which matches real hardware and which some real-world legacy bioses I'm
>> running rely on. Furthermore, aliasing in the isa-bios area is already the
>
>I wonder if this allows the guest to flash the bios now, replacing or breaking it which may be a new security issue.
The bios can already be flashed, just from different addresses. This series just adds another alias region through which flashing will be possible. AFAICS it doesn't impose new security issues.
Ping... The last patch still needs an R-b, the other patches are already on master.
Best regards,
Bernhard
> If so this may need some machine property to enable it or is that not a problem in practice?
>
>Regards,
>BALATON Zoltan
>
>> current behavior in the bios (a.k.a. ROM) case, so this series consolidates
>> behavior.
>>
>> For migration compatibility the aliasing is only performed on new versions of
>> the q34 and pc machine types.
>>
>> v3:
>> * Amend commit message with a diff of `info mtree` (Phil)
>> * Add comments for bios memory regions (Phil)
>>
>> v2:
>> * Don't leak bios memory regions (Phil)
>> * Add compat machinery (Michael)
>>
>> Testing done:
>> * `make check` with qemu-system-x86_64 (QEMU 8.2.2) installed. All tests
>> including migration tests pass.
>> * `make check-avocado`
>>
>> Best regards,
>> Bernhard
>>
>> Bernhard Beschow (6):
>> hw/i386/x86: Eliminate two if statements in x86_bios_rom_init()
>> hw/i386: Have x86_bios_rom_init() take X86MachineState rather than
>> MachineState
>> hw/i386/x86: Don't leak "isa-bios" memory regions
>> hw/i386/x86: Don't leak "pc.bios" memory region
>> hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init()
>> hw/i386/pc_sysfw: Alias rather than copy isa-bios region
>>
>> include/hw/i386/pc.h | 1 +
>> include/hw/i386/x86.h | 17 +++++++++++++++-
>> hw/i386/microvm.c | 2 +-
>> hw/i386/pc.c | 1 +
>> hw/i386/pc_piix.c | 3 +++
>> hw/i386/pc_q35.c | 2 ++
>> hw/i386/pc_sysfw.c | 17 ++++++++++------
>> hw/i386/x86.c | 45 ++++++++++++++++++++++---------------------
>> 8 files changed, 58 insertions(+), 30 deletions(-)
>>
>> --
>> 2.45.0
>>
>>
>>
next prev parent reply other threads:[~2024-05-14 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 17:55 [PATCH v3 0/6] X86: Alias isa-bios area and clean up Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 1/6] hw/i386/x86: Eliminate two if statements in x86_bios_rom_init() Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 2/6] hw/i386: Have x86_bios_rom_init() take X86MachineState rather than MachineState Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 3/6] hw/i386/x86: Don't leak "isa-bios" memory regions Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 4/6] hw/i386/x86: Don't leak "pc.bios" memory region Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 5/6] hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init() Bernhard Beschow
2024-05-08 17:55 ` [PATCH v3 6/6] hw/i386/pc_sysfw: Alias rather than copy isa-bios region Bernhard Beschow
2024-05-21 7:10 ` Bernhard Beschow
2024-05-21 7:13 ` Paolo Bonzini
2024-05-21 7:42 ` Michael S. Tsirkin
2024-05-08 20:39 ` [PATCH v3 0/6] X86: Alias isa-bios area and clean up BALATON Zoltan
2024-05-14 8:31 ` Bernhard Beschow [this message]
2024-05-08 22:10 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0F5CD4D8-4942-4E6C-A88D-EB715CAC2553@gmail.com \
--to=shentey@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).