poky.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: ciaran.courtney@ie.abb.com
To: poky@lists.yoctoproject.org
Subject: wic: swap partitions not added to fstab since 37b4fa7a102f1212843411bd1d97202ba9da0e19
Date: Wed, 26 Oct 2022 08:29:15 -0700	[thread overview]
Message-ID: <ZgRo.1666798155405253803.WhRZ@lists.yoctoproject.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi all,

Sorry for the unorthodox email, is this the right place to report bugs?

I believe that since wic:direct.py: ignore invalid mountpoints during fstab update · lgirdk/poky@37b4fa7 (github.com) ( https://github.com/lgirdk/poky/commit/37b4fa7a102f1212843411bd1d97202ba9da0e19 ) that swap partitions are being left out of /etc/fstab, I think the condition should be "if the mountpoint begins with a slash or is equal to swap"

I hope this appears obvious to someone how can simply commit it, I'm tight for time on following the lengthy contribution guidelines.

[-- Attachment #2: Type: text/html, Size: 623 bytes --]

             reply	other threads:[~2022-10-26 15:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 15:29 ciaran.courtney [this message]
2022-10-28 12:04 ` wic: swap partitions not added to fstab since 37b4fa7a102f1212843411bd1d97202ba9da0e19 ciaran.courtney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgRo.1666798155405253803.WhRZ@lists.yoctoproject.org \
    --to=ciaran.courtney@ie.abb.com \
    --cc=poky@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).