poky.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jörg Sommer" <joerg.sommer@navimatix.de>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	"poky@lists.yoctoproject.org" <poky@lists.yoctoproject.org>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [poky] [PATCH] runqemu-ifupdown: Add support for ip tuntap
Date: Fri, 9 Jun 2023 07:30:52 +0000	[thread overview]
Message-ID: <VI1PR0102MB3136877E03064F5A6FB075DDFC51A@VI1PR0102MB3136.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <5968fd664354f0ef7a8f41e93ddb6ff211016f0d.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

@openembedded: I have proposed a patch to runqemu-ifup/down to use `ip tuntap` as an alternative to tunctl for setting up the tap interface. Now the question came up if tunctl could be fully dropped.

On 8 June 2023 22:18, Richard Purdie wrote:
> On Thu, 2023-06-08 at 15:07 +0200, Jörg Sommer via
> lists.yoctoproject.org wrote:
> > The *ip* command supports the creation and destruction of TAP devices since
> > 2009 and might be more likely installed on systems then *tunctl*. Therefore
> > it should be tried to setup or teardown the TAP interface with *ip* before
> > falling back to *tunctl*.
> >
> > https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=580fbd88f75cc9eea0d28a48c025b090eb9419a7
> >
> > Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> > ---
> >  scripts/runqemu-ifdown | 14 ++++++++------
> >  scripts/runqemu-ifup   | 31 +++++++++++++++++++------------
> >  2 files changed, 27 insertions(+), 18 deletions(-)
>
> This does make me wonder if we could just drop tunctl now?

I think so. But do all systems support ip, now? If so, the part for ifconfig could be dropped.

> We originally had this as ifconfig couldn't do what we needed and ip
> was comparatively rare on systems. Things have changed and moved on!
>
> Did the gen-tap-devs script also need updating?

Yeah, you're right. I forgot about it.

> Also, this patch does need to go to the openembedded-core list as it is
> changing that repository which poky is built from.

Thanks for the pointing.

Mit freundlichen Grüßen


Jörg Sommer

Software Developer / Programmierer



--

Navimatix GmbH

Tatzendpromenade 2

07745 Jena


T: 03641 - 327 99 0

F: 03641 - 526 306

M: joerg.sommer@navimatix.de

www.navimatix.de






Geschäftsführer: Steffen Späthe, Jan Rommeley

Registergericht: Amtsgericht Jena, HRB 501480



[-- Attachment #2: Type: text/html, Size: 5479 bytes --]

      reply	other threads:[~2023-06-09  7:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 13:07 [PATCH] runqemu-ifupdown: Add support for ip tuntap Jörg Sommer
2023-06-08 20:18 ` [poky] " Richard Purdie
2023-06-09  7:30   ` Jörg Sommer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0102MB3136877E03064F5A6FB075DDFC51A@VI1PR0102MB3136.eurprd01.prod.exchangelabs.com \
    --to=joerg.sommer@navimatix.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=poky@lists.yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).