poky.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Kanavin <alex.kanavin@gmail.com>
To: m.glembo@gmail.com
Cc: poky@lists.yoctoproject.org,
	 Michael Glembotzki <Michael.Glembotzki@iris-sensing.com>
Subject: Re: [master][scarthgap][poky][PATCH] rootfs-postcommands.bbclass: Only set DROPBEAR_RSAKEY_DIR once
Date: Mon, 22 Apr 2024 16:13:49 +0200	[thread overview]
Message-ID: <CANNYZj_90xB+ZiBvU0B+KPP2pcb3vdtAPVPNpYnk8990Zn9z6A@mail.gmail.com> (raw)
In-Reply-To: <20240422135552.83928-1-Michael.Glembotzki@iris-sensing.com>

Incorrect mailing list. Please read poky/README.md

Alex

On Mon, 22 Apr 2024 at 15:56, Michael Glembotzki via
lists.yoctoproject.org <m.glembo=gmail.com@lists.yoctoproject.org>
wrote:
>
> If DROPBEAR_RSAKEY_DIR has already been set before, e.g. by overwriting
> the file dropbear.default, the line will still be appended a second time.
>
> DROPBEAR_RSAKEY_DIR="/path/to/dropbear"
> DROPBEAR_EXTRA_ARGS="-B"
> DROPBEAR_RSAKEY_DIR=/var/lib/dropbear
>
> Signed-off-by: Michael Glembotzki <Michael.Glembotzki@iris-sensing.com>
> ---
>  meta/classes-recipe/rootfs-postcommands.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/rootfs-postcommands.bbclass b/meta/classes-recipe/rootfs-postcommands.bbclass
> index e81b69a239..920da94ba2 100644
> --- a/meta/classes-recipe/rootfs-postcommands.bbclass
> +++ b/meta/classes-recipe/rootfs-postcommands.bbclass
> @@ -206,7 +206,9 @@ read_only_rootfs_hook () {
>                 # Also tweak the key location for dropbear in the same way.
>                 if [ -d ${IMAGE_ROOTFS}/etc/dropbear ]; then
>                         if [ ! -e ${IMAGE_ROOTFS}/etc/dropbear/dropbear_rsa_host_key ]; then
> -                               echo "DROPBEAR_RSAKEY_DIR=/var/lib/dropbear" >> ${IMAGE_ROOTFS}/etc/default/dropbear
> +                               if ! grep -q "^DROPBEAR_RSAKEY_DIR=" ${IMAGE_ROOTFS}/etc/default/dropbear ; then
> +                                       echo "DROPBEAR_RSAKEY_DIR=/var/lib/dropbear" >> ${IMAGE_ROOTFS}/etc/default/dropbear
> +                               fi
>                         fi
>                 fi
>         fi
> --
> 2.44.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#13331): https://lists.yoctoproject.org/g/poky/message/13331
> Mute This Topic: https://lists.yoctoproject.org/mt/105669771/1686489
> Group Owner: poky+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/poky/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


      reply	other threads:[~2024-04-22 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 13:55 [master][scarthgap][poky][PATCH] rootfs-postcommands.bbclass: Only set DROPBEAR_RSAKEY_DIR once Michael Glembotzki
2024-04-22 14:13 ` Alexander Kanavin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANNYZj_90xB+ZiBvU0B+KPP2pcb3vdtAPVPNpYnk8990Zn9z6A@mail.gmail.com \
    --to=alex.kanavin@gmail.com \
    --cc=Michael.Glembotzki@iris-sensing.com \
    --cc=m.glembo@gmail.com \
    --cc=poky@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).