From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Kate Hsuan" <hpa@redhat.com>, "Pavel Machek" <pavel@ucw.cz>,
"Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"André Apitzsch" <git@apitzsch.eu>,
linux-kernel@vger.kernel.org,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v6 4/5] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED
Date: Fri, 19 Apr 2024 13:14:49 +0200 [thread overview]
Message-ID: <ppwhxcsruclsdrvd6gfxwan3so2shtxyarml5rgi6fo4ukb7bi@a4b5acxh3w65> (raw)
In-Reply-To: <a9e8759e-4d30-4923-bcfd-4cd133fe950d@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
Hi,
On Fri, Apr 19, 2024 at 09:37:56AM +0200, Hans de Goede wrote:
> On 4/18/24 2:34 PM, Sebastian Reichel wrote:
> > On Tue, Apr 16, 2024 at 01:39:08PM +0800, Kate Hsuan wrote:
> >> Add a charging_orange_full_green LED trigger and the trigger is based on
> >> led_mc_trigger_event() which can set an RGB LED when the trigger is
> >> triggered. The LED will show orange when the battery status is charging.
> >> The LED will show green when the battery status is full.
> >>
> >> Link: https://lore.kernel.org/linux-leds/f40a0b1a-ceac-e269-c2dd-0158c5b4a1ad@gmail.com/
> >>
> >> Signed-off-by: Kate Hsuan <hpa@redhat.com>
> >> ---
> >
> > Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Thanks. Does this mean your ok with routing this change through the LED tree
> together with the 2 LED core patches adding the new led_mc_trigger_event()
> function this uses ?
Yes.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-19 11:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 5:39 [PATCH v6 0/5] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-04-16 5:39 ` [PATCH v6 1/5] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-04-16 13:45 ` Andy Shevchenko
2024-04-18 7:46 ` Kate Hsuan
2024-04-18 8:55 ` Hans de Goede
2024-04-16 5:39 ` [PATCH v6 2/5] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-04-16 17:29 ` Andy Shevchenko
2024-04-18 7:22 ` Kate Hsuan
2024-04-16 5:39 ` [PATCH v6 3/5] leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027 Kate Hsuan
2024-04-16 17:31 ` Andy Shevchenko
2024-04-18 7:01 ` Kate Hsuan
2024-04-16 5:39 ` [PATCH v6 4/5] power: supply: power-supply-leds: Add charging_orange_full_green trigger for RGB LED Kate Hsuan
2024-04-16 17:03 ` kernel test robot
2024-04-16 17:33 ` Andy Shevchenko
2024-04-18 6:40 ` Kate Hsuan
2024-04-16 23:27 ` kernel test robot
2024-04-18 12:34 ` Sebastian Reichel
2024-04-19 7:37 ` Hans de Goede
2024-04-19 11:14 ` Sebastian Reichel [this message]
2024-04-16 5:39 ` [PATCH v6 5/5] platform: x86-android-tablets: others: Set the LED trigger to charging_orange_full_green for Xiaomi pad2 Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ppwhxcsruclsdrvd6gfxwan3so2shtxyarml5rgi6fo4ukb7bi@a4b5acxh3w65 \
--to=sebastian.reichel@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=git@apitzsch.eu \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).