From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false
Date: Mon, 29 Apr 2024 12:03:41 +0200 [thread overview]
Message-ID: <e3489dce-9d9b-4d3e-82f5-b5ba6a2ef1f9@redhat.com> (raw)
In-Reply-To: <20240429093446.130322-1-hdegoede@redhat.com>
Hi,
On 4/29/24 11:34 AM, Hans de Goede wrote:
> acpi_send_ev is a bool and everywhere else true/false is used
> to set it. Replace the one instance using 0 with false.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 7e2288009063..e2e6c4d3dff7 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3912,7 +3912,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 event)
> if (tp_features.hotkey_wlsw &&
> hkey == TP_HKEY_EV_RFKILL_CHANGED) {
> tpacpi_send_radiosw_update();
> - send_acpi_ev = 0;
> + send_acpi_ev = false;
> known_ev = true;
> }
> break;
prev parent reply other threads:[~2024-04-29 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 9:34 [PATCH] platform/x86: thinkpad_acpi: Use false to set acpi_send_ev to false Hans de Goede
2024-04-29 9:38 ` Ilpo Järvinen
2024-04-29 10:03 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3489dce-9d9b-4d3e-82f5-b5ba6a2ef1f9@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).