From: Hans de Goede <hdegoede@redhat.com>
To: Kate Hsuan <hpa@redhat.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Lee Jones" <lee@kernel.org>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"André Apitzsch" <git@apitzsch.eu>,
linux-kernel@vger.kernel.org,
"Sebastian Reichel" <sre@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED
Date: Wed, 27 Mar 2024 21:08:38 +0100 [thread overview]
Message-ID: <adc4d0b8-412b-42b0-94fb-96bd6c23bb83@redhat.com> (raw)
In-Reply-To: <CAEth8oEps=T3JGJiCEH_SknjkcGaTXv+ekBQLgVRm+Nc7qfa1g@mail.gmail.com>
Hi,
On 3/27/24 7:09 AM, Kate Hsuan wrote:
> Hi Hans,
>
> On Tue, Mar 26, 2024 at 12:32 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
>>
>> On Mon, Mar 25, 2024 at 04:02:54PM +0100, Hans de Goede wrote:
>>> On 3/22/24 4:37 AM, Kate Hsuan wrote:
>>>> There is a KTD2026 LED controller to manage the indicator LED for Xiaomi
>>>> pad2. The ACPI for it is not properly made so the kernel can't get
>>>> a correct description of it.
>>>>
>>>> This work add a description for this RGB LED controller and also set a
>>>> trigger to indicate the chaging event (bq27520-0-charging). When it is
>>>> charging, the indicator LED will be turn on.
>>>>
>>>> Signed-off-by: Kate Hsuan <hpa@redhat.com>
>>>
>>> Thank you for your patch, I've applied this patch to my review-hans
>>> branch:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>>
>>> I will also merge [PATCH v5 6/6] platform: x86-android-tablets:
>>> others: Set the LED trigger to charging_red_full_green for Xiaomi pad2"
>>>
>>> Once the new power_supply trigger patch this relies on has been
>>> accepted.
>>>
>>> Once I've run some tests on this branch the patches there will be
>>> added to the platform-drivers-x86/for-next branch and eventually
>>> will be included in the pdx86 pull-request to Linus for the next
>>> merge-window.
>>
>> I believe I have commented on the "RESEND" version.
Right, sorry. Since there were just a few trivial comments
I've fixed them up in my review-hans branch now, thank you
for the review.
> Thank you for your reviewing.
> Please review the RESEND patch and I'll fix them according to Andy's comments.
No need to do a new version I've squashed fixed for Andy's remarks +
Andy's commit msg remarks into the version in my review-hans branch.
Note I'm going offline for a long weekend and I won't be
replying to emails until next week Tuesday.
Regards,
Hans
next prev parent reply other threads:[~2024-03-27 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 3:37 [PATCH v5 0/6] KTD2026 indicator LED for X86 Xiaomi Pad2 Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 1/6] platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 indicator LED Kate Hsuan
2024-03-25 15:02 ` Hans de Goede
2024-03-25 16:31 ` Andy Shevchenko
2024-03-27 6:09 ` Kate Hsuan
2024-03-27 20:08 ` Hans de Goede [this message]
2024-03-22 3:37 ` [PATCH v5 2/6] leds: rgb: leds-ktd202x: Get device properties through fwnode to support ACPI Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 3/6] leds: core: Add led_mc_set_brightness() function Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 4/6] leds: trigger: Add led_mc_trigger_event() function Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 5/6] power: supply: power-supply-leds: Add charging_red_full_green trigger for RGB LED Kate Hsuan
2024-03-22 3:37 ` [PATCH v5 6/6] platform: x86-android-tablets: others: Set the LED trigger to charging_red_full_green for Xiaomi pad2 Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc4d0b8-412b-42b0-94fb-96bd6c23bb83@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@intel.com \
--cc=git@apitzsch.eu \
--cc=hpa@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).