From: Hans de Goede <hdegoede@redhat.com>
To: "Joseph, Jithu" <jithu.joseph@intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
ilpo.jarvinen@linux.intel.com, markgross@kernel.org
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, ashok.raj@intel.com,
tony.luck@intel.com, rostedt@goodmis.org,
ravi.v.shankar@intel.com, patches@lists.linux.dev
Subject: Re: [PATCH 1/3] platform/x86/intel/ifs: Classify error scenarios correctly
Date: Mon, 15 Apr 2024 17:10:27 +0200 [thread overview]
Message-ID: <ab3caa8c-daf0-4d35-a7c7-b1a14f7bc1bb@redhat.com> (raw)
In-Reply-To: <57c32cfd-136d-4c72-9f4d-12599b508fb8@intel.com>
Hi,
Thank you for this patch series.
On 4/12/24 9:31 PM, Joseph, Jithu wrote:
> Sathya,
>
> Thanks for reviewing this
>
> On 4/12/2024 11:32 AM, Kuppuswamy Sathyanarayanan wrote:
>>
>> On 4/12/24 10:23 AM, Jithu Joseph wrote:
>>> Based on inputs from hardware architects, only "scan signature failures"
>>> should be treated as actual hardware/cpu failure.
>>
>> Instead of just saying input from hardware architects, it would be better
>> if you mention the rationale behind it.
>
> I can reword the first para as below:
>
> "Scan controller error" means that scan hardware encountered an error
> prior to doing an actual test on the target CPU. It does not mean that
> there is an actual cpu/core failure. "scan signature failure" indicates
> that the test result on the target core did not match the expected value
> and should be treated as a cpu failure.
>
> Current driver classifies both these scenarios as failures. Modify ...
I've modified the commit message using the rewording suggested above
while merging this patch and I have merged the entire series:
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>>> Current driver, in addition, classifies "scan controller error" scenario
>>> too as a hardware/cpu failure. Modify the driver to classify this situation
>>> with a more appropriate "untested" status instead of "fail" status.
>>>
>>> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
>>> Reviewed-by: Tony Luck <tony.luck@intel.com>
>>> Reviewe
>>
>> Code wise it looks good to me.
>>
>> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>
>
> Jithu
>
next prev parent reply other threads:[~2024-04-15 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 17:23 [PATCH 0/3] Miscelleanous In Field Scan changes Jithu Joseph
2024-04-12 17:23 ` [PATCH 1/3] platform/x86/intel/ifs: Classify error scenarios correctly Jithu Joseph
2024-04-12 18:32 ` Kuppuswamy Sathyanarayanan
2024-04-12 19:31 ` Joseph, Jithu
2024-04-12 20:46 ` Kuppuswamy Sathyanarayanan
2024-04-15 15:10 ` Hans de Goede [this message]
2024-04-12 17:23 ` [PATCH 2/3] platform/x86/intel/ifs: trace: display batch num in hex Jithu Joseph
2024-04-12 18:45 ` Kuppuswamy, Sathyanarayanan
2024-04-12 17:23 ` [PATCH 3/3] platform/x86/intel/ifs: Disable irq during one load stage Jithu Joseph
2024-04-12 19:13 ` Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab3caa8c-daf0-4d35-a7c7-b1a14f7bc1bb@redhat.com \
--to=hdegoede@redhat.com \
--cc=ashok.raj@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).