From: Hans de Goede <hdegoede@redhat.com>
To: "Nikita Travkin" <nikita@trvn.ru>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 0/4] platform: arm64: Acer Aspire 1 embedded controller
Date: Mon, 25 Mar 2024 15:50:59 +0100 [thread overview]
Message-ID: <a1cd7477-570b-48e1-b3fd-941b176bc9c0@redhat.com> (raw)
In-Reply-To: <20240315-aspire1-ec-v5-0-f93381deff39@trvn.ru>
Hi,
On 3/15/24 2:51 PM, Nikita Travkin wrote:
> The laptop contains an embedded controller that provides a set of
> features:
>
> - Battery and charger monitoring
> - USB Type-C DP alt mode HPD monitoring
> - Lid status detection
> - Small amount of keyboard configuration*
>
> [*] The keyboard is handled by the same EC but it has a dedicated i2c
> bus and is already enabled. This port only provides fn key behavior
> configuration.
>
> Unfortunately, while all this functionality is implemented in ACPI, it's
> currently not possible to use ACPI to boot Linux on such Qualcomm
> devices. Thus this series implements and enables a new driver that
> provides support for the EC features.
>
> The EC would be one of the last pieces to get almost full support for the
> Acer Aspire 1 laptop in the upstream Linux kernel.
>
> This series is similar to the EC driver for Lenovo Yoga C630, proposed
> in [1] but seemingly never followed up...
>
> [1] https://lore.kernel.org/all/20230205152809.2233436-1-dmitry.baryshkov@linaro.org/
>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
I've fixed the Kconfig typo Randy spotted while applying this.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes in v5:
> - Various cleanups (Bryan, Ilpo)
> - Add Bryan as Reviewer for platform/arm64 (Bryan, Ilpo)
> - Link to v4: https://lore.kernel.org/r/20240312-aspire1-ec-v4-0-bd8e3eea212f@trvn.ru
>
> Changes in v4:
> - Move to platform/arm64 (Sebastian, Hans)
> - Drop fn mode dt property (Rob)
> - Add fn_lock attribute in sysfs (Rob)
> - Report psy present correctly (Sebastian)
> - Link to v3: https://lore.kernel.org/r/20240220-aspire1-ec-v3-0-02cb139a4931@trvn.ru
>
> Changes in v3:
> - Supress warning on few no-op events.
> - Invert the fn key behavior (Rob, Conor)
> - Link to v2: https://lore.kernel.org/r/20231212-aspire1-ec-v2-0-ca495ea0a7ac@trvn.ru
>
> Changes in v2:
> - Drop incorrectly allowed reg in the ec connector binding (Krzysztof)
> - Minor style changes (Konrad)
> - Link to v1: https://lore.kernel.org/r/20231207-aspire1-ec-v1-0-ba9e1c227007@trvn.ru
>
> ---
> Nikita Travkin (4):
> dt-bindings: platform: Add Acer Aspire 1 EC
> platform: Add ARM64 platform directory
> platform: arm64: Add Acer Aspire 1 embedded controller driver
> arm64: dts: qcom: acer-aspire1: Add embedded controller
>
> .../bindings/platform/acer,aspire1-ec.yaml | 60 +++
> MAINTAINERS | 16 +
> arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 40 +-
> drivers/platform/Kconfig | 2 +
> drivers/platform/Makefile | 1 +
> drivers/platform/arm64/Kconfig | 35 ++
> drivers/platform/arm64/Makefile | 8 +
> drivers/platform/arm64/acer-aspire1-ec.c | 562 +++++++++++++++++++++
> 8 files changed, 723 insertions(+), 1 deletion(-)
> ---
> base-commit: a1e7655b77e3391b58ac28256789ea45b1685abb
> change-id: 20231206-aspire1-ec-6b3d2cac1a72
>
> Best regards,
prev parent reply other threads:[~2024-03-25 14:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 13:51 [PATCH v5 0/4] platform: arm64: Acer Aspire 1 embedded controller Nikita Travkin
2024-03-15 13:51 ` [PATCH v5 1/4] dt-bindings: platform: Add Acer Aspire 1 EC Nikita Travkin
2024-03-15 13:51 ` [PATCH v5 2/4] platform: Add ARM64 platform directory Nikita Travkin
2024-03-18 11:31 ` Ilpo Järvinen
2024-03-15 13:51 ` [PATCH v5 3/4] platform: arm64: Add Acer Aspire 1 embedded controller driver Nikita Travkin
2024-03-15 15:04 ` Randy Dunlap
2024-03-18 11:53 ` Ilpo Järvinen
2024-03-15 13:51 ` [PATCH v5 4/4] arm64: dts: qcom: acer-aspire1: Add embedded controller Nikita Travkin
2024-03-25 14:50 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1cd7477-570b-48e1-b3fd-941b176bc9c0@redhat.com \
--to=hdegoede@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).