From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: 艾超 <aichao@kylinos.cn>,
"ilpo.jarvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
platform-driver-x86 <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v11] platform/x86: add lenovo wmi camera button driver
Date: Thu, 28 Mar 2024 17:18:09 +0200 [thread overview]
Message-ID: <ZgWKMUKmEhYtlyQ0@smile.fi.intel.com> (raw)
In-Reply-To: <4b6aa3ef-82f1-43d4-9544-89f591f49e41@redhat.com>
On Wed, Mar 27, 2024 at 09:03:38PM +0100, Hans de Goede wrote:
> On 3/27/24 2:14 PM, Andy Shevchenko wrote:
> > On Wed, Mar 27, 2024 at 11:54:55AM +0100, Hans de Goede wrote:
> >> On 3/26/24 3:54 AM, 艾超 wrote:
...
> >>>>> +config LENOVO_WMI_CAMERA
> >>>>> + tristate "Lenovo WMI Camera Button driver"
> >>>>> + depends on ACPI_WMI
> >>>>> + depends on INPUT
> >>>
> >>>> No COMPILE_TEST?
> >>>
> >>> I compile this driver and used Evtest tool to test it on lenovo A70.
> >
> > What I meant here is to add respective COMPILE_TEST to the dependency(ies).
>
> Neither include/linux/input.h nor include/linux/wmi.h offer
> stubs when disabled so this will not work.
Oh, I didn't realize that!
> Besides x86 has a lot of compile test coverage in general,
> so I don't see much value in adding || COMPILE_TEST to
> dependencies.
Agree.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-28 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <je8phmmtfz-je9zfg1v9s@nsmail7.0.0--kylin--1>
2024-03-27 10:54 ` [PATCH v11] platform/x86: add lenovo wmi camera button driver Hans de Goede
2024-03-27 13:14 ` Andy Shevchenko
2024-03-27 20:03 ` Hans de Goede
2024-03-28 15:18 ` Andy Shevchenko [this message]
2024-03-22 6:47 Ai Chao
2024-03-22 14:34 ` Kuppuswamy Sathyanarayanan
2024-03-22 14:39 ` Ilpo Järvinen
2024-03-22 16:47 ` Kuppuswamy Sathyanarayanan
2024-03-22 18:48 ` Armin Wolf
2024-03-25 15:01 ` Hans de Goede
2024-03-25 16:29 ` Andy Shevchenko
2024-03-26 20:59 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgWKMUKmEhYtlyQ0@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=aichao@kylinos.cn \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).