From: Hans de Goede <hdegoede@redhat.com>
To: Armin Wolf <W_Armin@gmx.de>, ilpo.jarvinen@linux.intel.com
Cc: corbet@lwn.net, sathyanarayanan.kuppuswamy@linux.intel.com,
linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] platform/x86: wmi: Mark simple WMI drivers as legacy-free
Date: Mon, 8 Apr 2024 17:40:44 +0200 [thread overview]
Message-ID: <7d1cd4f6-118a-4dbf-a882-4c13386a0e18@redhat.com> (raw)
In-Reply-To: <20240402143059.8456-1-W_Armin@gmx.de>
Hi,
On 4/2/24 4:30 PM, Armin Wolf wrote:
> The inspur_platform_profile driver and the xiaomi-wmi driver both
> meet the requirements for modern WMI drivers, as they both do not
> use the legacy GUID-based interface and can be safely instantiated
> multiple times.
>
> Mark them both as legacy-free using the no_singleton flag.
>
> Compile-tested only.
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes since v1:
> - add Reviewed-by tag
> ---
> drivers/platform/x86/inspur_platform_profile.c | 1 +
> drivers/platform/x86/xiaomi-wmi.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/inspur_platform_profile.c b/drivers/platform/x86/inspur_platform_profile.c
> index 743705bddda3..8440defa6788 100644
> --- a/drivers/platform/x86/inspur_platform_profile.c
> +++ b/drivers/platform/x86/inspur_platform_profile.c
> @@ -207,6 +207,7 @@ static struct wmi_driver inspur_wmi_driver = {
> .id_table = inspur_wmi_id_table,
> .probe = inspur_wmi_probe,
> .remove = inspur_wmi_remove,
> + .no_singleton = true,
> };
>
> module_wmi_driver(inspur_wmi_driver);
> diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
> index 54a2546bb93b..1f5f108d87c0 100644
> --- a/drivers/platform/x86/xiaomi-wmi.c
> +++ b/drivers/platform/x86/xiaomi-wmi.c
> @@ -83,6 +83,7 @@ static struct wmi_driver xiaomi_wmi_driver = {
> .id_table = xiaomi_wmi_id_table,
> .probe = xiaomi_wmi_probe,
> .notify = xiaomi_wmi_notify,
> + .no_singleton = true,
> };
> module_wmi_driver(xiaomi_wmi_driver);
>
> --
> 2.39.2
>
prev parent reply other threads:[~2024-04-08 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:30 [PATCH v2 1/4] platform/x86: wmi: Mark simple WMI drivers as legacy-free Armin Wolf
2024-04-02 14:30 ` [PATCH v2 2/4] platform/x86: xiaomi-wmi: Fix race condition when reporting key events Armin Wolf
2024-04-02 21:17 ` Kuppuswamy Sathyanarayanan
2024-04-02 14:30 ` [PATCH v2 3/4] platform/x86: xiaomi-wmi: Drop unnecessary NULL checks Armin Wolf
2024-04-02 21:16 ` Kuppuswamy Sathyanarayanan
2024-04-02 14:30 ` [PATCH v2 4/4] platform/x86: wmi: Add driver development guide Armin Wolf
2024-04-02 21:16 ` Kuppuswamy Sathyanarayanan
2024-04-08 15:40 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d1cd4f6-118a-4dbf-a882-4c13386a0e18@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=corbet@lwn.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).