From: Hans de Goede <hdegoede@redhat.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: ilpo.jarvinen@linux.intel.com,
"open list:X86 PLATFORM DRIVERS"
<platform-driver-x86@vger.kernel.org>,
Suma Hegde <suma.hegde@amd.com>
Subject: Re: [PATCH 0/3] platform/x86/amd/hsmp: ACPI, Non-ACPI code split and other misc changes
Date: Mon, 29 Apr 2024 10:50:38 +0200 [thread overview]
Message-ID: <48163b9f-7aba-4874-8fb7-98bebc370548@redhat.com> (raw)
In-Reply-To: <a0a27a27-0deb-41c5-9625-ddaebf42f405@amd.com>
Hi Mario,
On 4/23/24 7:07 PM, Mario Limonciello wrote:
> On 4/23/2024 04:14, Suma Hegde wrote:
>> Patch1:
>> The first patch is to address the concerns mentioned by Limonciello,
>> Mario i.e to address the issue of
>> "Probing registers that don't match the same mailboxes randomly on
>> client or embedded parts might lead to unexpected behaviors".
>>
>> Because of some limitations, instead of the methods suggested by Mario,
>> family check is added to differentiate server socs and client socs.
>> This check is only for backward compatibility, Going forward all
>> systems will have ACPI based probing only.
>>
>
> Thanks! Hans, please drop the PM profile patch from your review queue in favor of this series instead.
You mean: "platform/x86/amd: Don't allow HSMP to be loaded on non-server hardware", right ?
now dropped.
Regards,
Hans
>
>>
>> Patch2:
>> The second patch splits ACPI code into separate file there by removing the
>> dependency of ACPI in Kconfig.
>> This is based on the suggestion from Ilpo Jarvinen.
>>
>>
>> Patch3:
>> The third patch makes HSMP as "default m" so that anyone who uses standard
>> distros will be able to use HSMP by dynamically loading it.
>>
>>
>> Suma Hegde (3):
>> platform/x86/amd/hsmp: Check HSMP support on AMD family of processors
>> platform/x86/amd/hsmp: Split the ACPI and non-ACPI code
>> platform/x86/amd/hsmp: Make HSMP as default m
>>
>> MAINTAINERS | 2 +-
>> drivers/platform/x86/amd/Kconfig | 14 +-
>> drivers/platform/x86/amd/Makefile | 3 +-
>> drivers/platform/x86/amd/hsmp/Kconfig | 18 +
>> drivers/platform/x86/amd/hsmp/Makefile | 9 +
>> drivers/platform/x86/amd/hsmp/hsmp-acpi.c | 219 ++++++++++++
>> drivers/platform/x86/amd/{ => hsmp}/hsmp.c | 378 +++++----------------
>> drivers/platform/x86/amd/hsmp/hsmp.h | 82 +++++
>> 8 files changed, 425 insertions(+), 300 deletions(-)
>> create mode 100644 drivers/platform/x86/amd/hsmp/Kconfig
>> create mode 100644 drivers/platform/x86/amd/hsmp/Makefile
>> create mode 100644 drivers/platform/x86/amd/hsmp/hsmp-acpi.c
>> rename drivers/platform/x86/amd/{ => hsmp}/hsmp.c (71%)
>> create mode 100644 drivers/platform/x86/amd/hsmp/hsmp.h
>>
>
prev parent reply other threads:[~2024-04-29 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:14 [PATCH 0/3] platform/x86/amd/hsmp: ACPI, Non-ACPI code split and other misc changes Suma Hegde
2024-04-23 9:14 ` [PATCH 1/3] platform/x86/amd/hsmp: Check HSMP support on AMD family of processors Suma Hegde
2024-04-23 17:11 ` Mario Limonciello
2024-04-25 10:03 ` Hegde, Suma
2024-04-23 9:14 ` [PATCH 2/3] platform/x86/amd/hsmp: Split the ACPI and non-ACPI code Suma Hegde
2024-04-23 17:13 ` Mario Limonciello
2024-04-23 9:14 ` [PATCH 3/3] platform/x86/amd/hsmp: Make HSMP as default m Suma Hegde
2024-04-23 17:17 ` Mario Limonciello
2024-04-25 6:59 ` Hegde, Suma
2024-04-23 17:07 ` [PATCH 0/3] platform/x86/amd/hsmp: ACPI, Non-ACPI code split and other misc changes Mario Limonciello
2024-04-29 8:50 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48163b9f-7aba-4874-8fb7-98bebc370548@redhat.com \
--to=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).