From: Hans de Goede <hdegoede@redhat.com>
To: Ai Chao <aichao@kylinos.cn>,
corentin.chary@gmail.com, luke@ljones.dev,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform/x86: asus-wmi: use sysfs_emit() instead of sprintf()
Date: Mon, 25 Mar 2024 15:42:25 +0100 [thread overview]
Message-ID: <407f241f-e185-4586-9f75-9beb73902870@redhat.com> (raw)
In-Reply-To: <20240319055636.150289-1-aichao@kylinos.cn>
Hi,
On 3/19/24 6:56 AM, Ai Chao wrote:
> This changes all *_show attributes in asus-wmi.c to use sysfs_emit()
> instead of the older method of writing to the output buffer manually.
>
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 3f07bbf809ef..df4c103459da 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2326,7 +2326,7 @@ static ssize_t pwm1_show(struct device *dev,
>
> /* If we already set a value then just return it */
> if (asus->agfn_pwm >= 0)
> - return sprintf(buf, "%d\n", asus->agfn_pwm);
> + return sysfs_emit(buf, "%d\n", asus->agfn_pwm);
>
> /*
> * If we haven't set already set a value through the AGFN interface,
> @@ -2512,8 +2512,8 @@ static ssize_t asus_hwmon_temp1(struct device *dev,
> if (err < 0)
> return err;
>
> - return sprintf(buf, "%ld\n",
> - deci_kelvin_to_millicelsius(value & 0xFFFF));
> + return sysfs_emit(buf, "%ld\n",
> + deci_kelvin_to_millicelsius(value & 0xFFFF));
> }
>
> /* GPU fan on modern ROG laptops */
> @@ -4061,7 +4061,7 @@ static ssize_t show_sys_wmi(struct asus_wmi *asus, int devid, char *buf)
> if (value < 0)
> return value;
>
> - return sprintf(buf, "%d\n", value);
> + return sysfs_emit(buf, "%d\n", value);
> }
>
> #define ASUS_WMI_CREATE_DEVICE_ATTR(_name, _mode, _cm) \
prev parent reply other threads:[~2024-03-25 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 5:56 [PATCH v1] platform/x86: asus-wmi: use sysfs_emit() instead of sprintf() Ai Chao
2024-03-25 14:42 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407f241f-e185-4586-9f75-9beb73902870@redhat.com \
--to=hdegoede@redhat.com \
--cc=aichao@kylinos.cn \
--cc=corentin.chary@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).