From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Gwendal Grignou <gwendal@chromium.org>,
hdegoede@redhat.com, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: intel-vbtn: Use acpi_has_method to check for switch
Date: Mon, 8 Apr 2024 18:44:11 +0300 (EEST) [thread overview]
Message-ID: <24fa2a92-78bd-f563-d848-2b9b557dade5@linux.intel.com> (raw)
In-Reply-To: <030a3bb8-6246-4289-b188-65ad3fc72d62@linux.intel.com>
On Fri, 29 Mar 2024, Kuppuswamy Sathyanarayanan wrote:
> On 3/29/24 7:32 AM, Gwendal Grignou wrote:
> > To mimic how we check if the device has virtual buttons,
> > acpi_has_method(..."VBDL"), use the same method for checking virtual
> > switch presence.
>
> if possible don't use words like we/I in the commit log.
>
> Other wise, it looks fine.
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Thanks all.
I've applied these into review-ilpo branch. I edited the commit message
to get rid of "we" while applying.
--
i.
next prev parent reply other threads:[~2024-04-08 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 14:32 [PATCH 0/2] platform/x86: intel-vbtn: Fix ASUS VivoBook boot state Gwendal Grignou
2024-03-29 14:32 ` [PATCH 1/2] platform/x86: intel-vbtn: Use acpi_has_method to check for switch Gwendal Grignou
2024-03-29 18:49 ` Kuppuswamy Sathyanarayanan
2024-04-08 15:44 ` Ilpo Järvinen [this message]
2024-03-29 14:32 ` [PATCH 2/2] platform/x86: intel-vbtn: Update tablet mode switch at end of probe Gwendal Grignou
2024-03-29 18:50 ` Kuppuswamy Sathyanarayanan
2024-04-08 13:17 ` [PATCH 0/2] platform/x86: intel-vbtn: Fix ASUS VivoBook boot state Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24fa2a92-78bd-f563-d848-2b9b557dade5@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).