From: Pavel Machek <pavel@ucw.cz>
To: Caleb Connolly <caleb.connolly@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED
Date: Sat, 28 Oct 2023 12:39:27 +0200 [thread overview]
Message-ID: <ZTzk39tQlYlpo2rU@localhost> (raw)
In-Reply-To: <20231001-b4-sdm845-flash-dts-v1-1-275a3abb0b10@linaro.org>
Hi!
> + led-1 {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_YELLOW>;
That's warm white, not yellow. We should likely create a define for
that.
BR,
Pavel
--
next prev parent reply other threads:[~2023-10-28 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 17:19 [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Caleb Connolly
2023-10-01 17:19 ` [PATCH 1/2] arm64: dts: qcom: sdm845-oneplus: enable flash LED Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-28 10:39 ` Pavel Machek [this message]
2023-10-01 17:19 ` [PATCH 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable flash led Caleb Connolly
2023-10-02 9:15 ` Konrad Dybcio
2023-10-22 15:50 ` [PATCH 0/2] dts: qcom: enable flash LED on OnePlus 6 and PocoPhone F1 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTzk39tQlYlpo2rU@localhost \
--to=pavel@ucw.cz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).