From: "Karel Balej" <balejk@matfyz.cz>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v6 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC
Date: Sun, 05 May 2024 20:52:06 +0200 [thread overview]
Message-ID: <D11XRKUAK8EM.20N91SDPCH584@matfyz.cz> (raw)
In-Reply-To: <ZjeidfoIbjvejphU@finisterre.sirena.org.uk>
Mark Brown, 2024-05-06T00:15:01+09:00:
> On Sat, May 04, 2024 at 09:37:06PM +0200, Karel Balej wrote:
>
> > +static const struct regulator_ops pm886_ldo_ops = {
> > + .list_voltage = regulator_list_voltage_table,
> > + .map_voltage = regulator_map_voltage_iterate,
> > + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> > + .get_voltage_sel = regulator_get_voltage_sel_regmap,
> > + .enable = regulator_enable_regmap,
> > + .disable = regulator_disable_regmap,
> > + .is_enabled = regulator_is_enabled_regmap,
> > + .get_current_limit = pm886_regulator_get_ilim,
>
> Do these regulators actually enforce this limit or is this just a spec
> limit beyond which regulation may fail? If it's just a spec limit I'd
> not expect this operation to be provided, it's more for a hard limit
> where the regulator will detect and act on issues. I don't see an error
> interrupt or anything and this would be an unusual feature for a LDO.
I'm afraid I don't have the answer -- my only reference is the vendor
version of the driver and I don't see anything there based on which I
would be able to tell.
But based on what you write, my guess would be that it's just a spec limit.
Should I then drop this op and the max_uA values from all the
regulators?
Thank you,
K. B.
next prev parent reply other threads:[~2024-05-05 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 19:37 [PATCH v6 0/5] initial support for Marvell 88PM886 PMIC Karel Balej
2024-05-04 19:37 ` [PATCH v6 1/5] dt-bindings: mfd: add entry " Karel Balej
2024-05-04 19:37 ` [PATCH v6 2/5] mfd: add driver " Karel Balej
2024-05-31 10:24 ` Lee Jones
2024-05-31 12:25 ` Karel Balej
2024-05-04 19:37 ` [PATCH v6 3/5] regulator: add regulators " Karel Balej
2024-05-05 15:15 ` Mark Brown
2024-05-05 18:52 ` Karel Balej [this message]
2024-05-06 1:04 ` Mark Brown
2024-05-04 19:37 ` [PATCH v6 4/5] input: add onkey " Karel Balej
2024-05-04 19:37 ` [PATCH v6 5/5] MAINTAINERS: add myself " Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D11XRKUAK8EM.20N91SDPCH584@matfyz.cz \
--to=balejk@matfyz.cz \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=duje.mihanovic@skole.hr \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).