Phone-Devel Archive mirror.
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: David Wronek <davidwronek@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, cros-qcom-dts-watchers@chromium.org
Subject: Re: [PATCH v5 3/4] arm64: dts: qcom: Add SM7125 device tree
Date: Fri, 20 Oct 2023 14:42:06 -0500	[thread overview]
Message-ID: <CAL_JsqKG0icvs1y1SMpdgk9mTk9pFziPo2YFjwhcgdkHdaV6KQ@mail.gmail.com> (raw)
In-Reply-To: <20230824091737.75813-4-davidwronek@gmail.com>

On Thu, Aug 24, 2023 at 4:17 AM David Wronek <davidwronek@gmail.com> wrote:
>
> The Snapdragon 720G (sm7125) is software-wise very similar to the
> Snapdragon 7c with minor differences in clock speeds and as added here,
> it uses the Kryo 465 instead of Kryo 468.
>
> Signed-off-by: David Wronek <davidwronek@gmail.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> new file mode 100644
> index 000000000000..12dd72859a43
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#include "sc7180.dtsi"
> +
> +/* SM7125 uses Kryo 465 instead of Kryo 468 */
> +&CPU0 { compatible = "qcom,kryo465"; };
> +&CPU1 { compatible = "qcom,kryo465"; };
> +&CPU2 { compatible = "qcom,kryo465"; };
> +&CPU3 { compatible = "qcom,kryo465"; };
> +&CPU4 { compatible = "qcom,kryo465"; };
> +&CPU5 { compatible = "qcom,kryo465"; };
> +&CPU6 { compatible = "qcom,kryo465"; };
> +&CPU7 { compatible = "qcom,kryo465"; };

This compatible is not documented. Please add it.

Rob

  reply	other threads:[~2023-10-20 19:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  9:15 [PATCH v5 0/4] Add initial support for SM7125 and Xiaomi SM7125 platform David Wronek
2023-08-24  9:15 ` [PATCH v5 1/4] dt-bindings: arm: qcom: Document SM7125 and xiaomi,joyeuse board David Wronek
2023-08-24  9:15 ` [PATCH v5 2/4] arm64: dts: qcom: pm6150: Add resin and rtc nodes David Wronek
2023-08-24  9:15 ` [PATCH v5 3/4] arm64: dts: qcom: Add SM7125 device tree David Wronek
2023-10-20 19:42   ` Rob Herring [this message]
2023-08-24  9:15 ` [PATCH v5 4/4] arm64: dts: qcom: Add support for the Xiaomi SM7125 platform David Wronek
2023-08-24  9:53 ` [PATCH v5 0/4] Add initial support for SM7125 and " Konrad Dybcio
2023-08-24 10:38   ` David Wronek
2023-09-20  3:58 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqKG0icvs1y1SMpdgk9mTk9pFziPo2YFjwhcgdkHdaV6KQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=davidwronek@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).