From: Kalle Valo <kvalo@kernel.org>
To: Dylan Van Assche <me@dylanvanassche.be>
Cc: ath10k@lists.infradead.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: ath10k-firmware: WCN3990: Add board file for Xiaomi POCOPHONE F1
Date: Thu, 07 Dec 2023 16:57:12 +0200 [thread overview]
Message-ID: <877clqnjqv.fsf@kernel.org> (raw)
In-Reply-To: <b4989ba4-5d14-0683-d3a9-cf0e983fa921@dylanvanassche.be> (Dylan Van Assche's message of "Fri, 25 Aug 2023 17:16:17 +0200")
Dylan Van Assche <me@dylanvanassche.be> writes:
> I would like to include the board file for the Xiaomi POCOPHONE F1
> smartphone.
> This smartphone is manufactured by Xiaomi and uses the Snapdragon
> SDM845 SoC.
> At postmarketOS, we run the mainline kernel on this phone so shipping
> this board file
> from upstream would be a great addition. A variant property was needed
> to avoid colliding
> with other SDM8845-based smartphones since they all share the same
> qmi-board-id and qmi-chip-id values.
>
> Below, the questions from the wiki:
>
> * description for what hardware this is:
>
> Smartphone with a SDM845 chip and a WCN3990 Bluetooth/WiFi chip.
> The WCN3990 chip is connected to 2 QM488xx radios, one is used
> for 2.4Ghz and the other one for 5Ghz radio.
>
> * origin of the board file (did you create it yourself or where you
> downloaded)
>
> Extracted from the stock firmware.
>
> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>
> - WCN3990 hw1.0
> + bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=xiaomi_beryllium
> sha256sum:
> 470a670fa15fd1f5625246556c83cb3aa811b0e954813da518e241e3a48bf4a2
> md5sum: 0655a0b7865c13172c43422c035d02a2
>
> * attach the actual board file (board.bin)
>
> The name of the files are equal to the id string in the board-2.bin
> (minus the ".bin")
Thanks, added to WCN3990/hw1.0/board-2.bin:
New:
bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=xiaomi_beryllium
Changed:
Deleted:
1 board image(s) added, 0 changed, 0 deleted, 26 in total
https://github.com/kvalo/ath10k-firmware/commit/a041131869db6eadcf0d4533e5b340a81d055a3b
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-12-07 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:16 ath10k-firmware: WCN3990: Add board file for Xiaomi POCOPHONE F1 Dylan Van Assche
2023-12-07 14:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877clqnjqv.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).