From: Stefan Hansson <newbyte@postmarketos.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535)
Date: Tue, 31 Oct 2023 14:52:15 +0100 [thread overview]
Message-ID: <714040ef-a032-41b4-9612-c739ecc25d33@postmarketos.org> (raw)
In-Reply-To: <a3162513-c4d0-4db6-9ff9-447f4249fc67@linaro.org>
On 2023-10-31 12:08, Konrad Dybcio wrote:
> On 25.10.2023 10:37, Stefan Hansson wrote:
>> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
>> based on the MSM8926 platform.
>>
>> Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
>> ---
>> arch/arm/boot/dts/qcom/Makefile | 1 +
>> .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++++++++++++++++++
>> 2 files changed, 37 insertions(+)
>> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>>
>> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
>> index a3d293e40820..cab35eeb30f6 100644
>> --- a/arch/arm/boot/dts/qcom/Makefile
>> +++ b/arch/arm/boot/dts/qcom/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>> qcom-msm8916-samsung-serranove.dtb \
>> qcom-msm8926-microsoft-superman-lte.dtb \
>> qcom-msm8926-microsoft-tesla.dtb \
>> + qcom-msm8926-samsung-matisselte.dtb \
>> qcom-msm8960-cdp.dtb \
>> qcom-msm8960-samsung-expressatt.dtb \
>> qcom-msm8974-lge-nexus5-hammerhead.dtb \
>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> new file mode 100644
>> index 000000000000..6e25b1a74ce5
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> @@ -0,0 +1,36 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2022, Matti Lehtimäki <matti.lehtimaki@gmail.com>
>> + * Copyright (c) 2023, Stefan Hansson <newbyte@postmarketos.org>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
>> +
>> +/ {
>> + model = "Samsung Galaxy Tab 4 10.1 LTE";
>> + compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
>> + chassis-type = "tablet";
>> +};
>> +
>> +&pm8226_l3 {
>> + regulator-max-microvolt = <1350000>;
>> +};
>> +
>> +&pm8226_s4 {
>> + regulator-max-microvolt = <2200000>;
>> +};
>> +
>> +®_tsp_3p3v {
>> + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
>> +};
>> +
>> +&sdhc_2 {
>> + /* SD card fails to probe with error -110 */
>> + status = "disabled";
> Can you give us some logs?
I tested it again just now, and it worked without issues. Maybe I used a
defective SD card to test it or hadn't inserted it properly. I'll send
another revision fixing this.
> Konrad
Stefan
next prev parent reply other threads:[~2023-10-31 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:37 [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi Stefan Hansson
2023-10-25 8:37 ` [PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree Stefan Hansson
2023-10-25 8:52 ` Krzysztof Kozlowski
2023-10-25 8:37 ` [PATCH v3 2/4] dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE Stefan Hansson
2023-10-25 8:48 ` Krzysztof Kozlowski
2023-10-25 8:50 ` Stefan Hansson
2023-10-25 8:37 ` [PATCH v3 3/4] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535) Stefan Hansson
2023-10-31 11:08 ` Konrad Dybcio
2023-10-31 13:52 ` Stefan Hansson [this message]
2023-10-25 8:37 ` [PATCH v3 4/4] ARM: dts: qcom: samsung-matisse-common: Add UART Stefan Hansson
2023-10-31 11:08 ` Konrad Dybcio
2023-10-25 8:48 ` [PATCH v3 0/4] Add samsung-matisselte and common matisse dtsi Krzysztof Kozlowski
2023-10-25 8:52 ` Stefan Hansson
2023-10-25 8:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714040ef-a032-41b4-9612-c739ecc25d33@postmarketos.org \
--to=newbyte@postmarketos.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).