From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>, Rob Herring <robh@kernel.org>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/6] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC
Date: Mon, 19 Feb 2024 08:29:42 +0100 [thread overview]
Message-ID: <6d9b1197-0dda-430d-8429-57c6ef98e48e@linaro.org> (raw)
In-Reply-To: <CZ8ATPJTOA3U.2QJSJY50EX2YH@gimli.ms.mff.cuni.cz>
On 18/02/2024 16:10, Karel Balej wrote:
> Rob Herring, 2024-02-15T08:20:52-06:00:
>>> .../bindings/mfd/marvell,88pm88x.yaml | 74 +++++++++++++++++++
>>
>> Filename should match the compatible.
>>
>> In general, drop the 'x' wildcard.
>
> By "in general", do you mean for the drivers code also?
No, not driver. The rules for wildcard, that they are discouraged, are
DT binding rules.
>
> As I have mentioned in the commit message for the driver, the other
> device is very similar and if the support for it was ever to be added
> (which I personally currently have no interest in), I believe it would
> make sense to extend this driver. Is it then still prefered to call it
> all just 88pm886 now?
Extend the driver, it's unrelated. Binding still should be named like
compatible, because that extension might never happen.
>
>>> +properties:
>>> + compatible:
>>> + const: marvell,88pm886-a1
>
> So the file should be called marvell,88pm886-a1.yaml, correct? Again, is
> it prefered to call it like this even if the other revision could
> eventually be added (again, I am not interested in that right now
If you already add two devices, flexible name would be fine. But you do
not add it now and you might never add, so keep the filename=compatible.
It is fine if it has also other compatibles later. We already accepted
many bindings like that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-19 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 9:35 [RFC PATCH v2 0/6] support for Marvell 88PM886 PMIC Karel Balej
2024-02-11 9:35 ` [RFC PATCH v2 1/6] dt-bindings: mfd: add entry " Karel Balej
2024-02-15 14:20 ` Rob Herring
2024-02-18 15:10 ` Karel Balej
2024-02-19 7:29 ` Krzysztof Kozlowski [this message]
2024-02-11 9:35 ` [RFC PATCH v2 2/6] mfd: add driver " Karel Balej
2024-02-11 9:35 ` [RFC PATCH v2 3/6] regulator: add regulators " Karel Balej
2024-02-11 9:35 ` [RFC PATCH v2 4/6] dt-bindings: input: add entry for Marvell 88PM88X PMICs onkey Karel Balej
2024-02-15 14:22 ` Rob Herring
2024-02-11 9:35 ` [RFC PATCH v2 5/6] input: add onkey driver for Marvell 88PM88X PMICs Karel Balej
2024-02-11 9:35 ` [RFC PATCH v2 6/6] MAINTAINERS: add myself for Marvell 88PM886 PMIC Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9b1197-0dda-430d-8429-57c6ef98e48e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=duje.mihanovic@skole.hr \
--cc=karelb@gimli.ms.mff.cuni.cz \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).