From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] MSM8976 MDSS/GPU/WCNSS support
Date: Wed, 24 Apr 2024 01:01:14 +0100 [thread overview]
Message-ID: <4028de21-33ea-4172-904f-e6809ef9a878@linaro.org> (raw)
In-Reply-To: <20240413170317.34553-1-a39.skl@gmail.com>
On 13/04/2024 18:03, Adam Skladowski wrote:
> This patch series provide support for display subsystem, gpu
> and also adds wireless connectivity subsystem support.
>
> Changes since v2
> ================
> 1. Disabled mdss_dsi nodes by default
> 2. Changed reg size of mdss_dsi0 to be equal on both
> 3. Added operating points to second mdss_dsi
> 4. Brought back required opp-supported-hw on adreno
> 5. Moved status under operating points on adreno
>
> Changes since v1
> ================
> 1. Addressed feedback
> 2. Dropped already applied dt-bindings patches
> 3. Dropped sdc patch as it was submitted as part of other series
> 4. Dropped dt-bindings patch for Adreno, also separate now
>
> Adam Skladowski (4):
> arm64: dts: qcom: msm8976: Add IOMMU nodes
> arm64: dts: qcom: msm8976: Add MDSS nodes
> arm64: dts: qcom: msm8976: Add Adreno GPU
> arm64: dts: qcom: msm8976: Add WCNSS node
>
> arch/arm64/boot/dts/qcom/msm8976.dtsi | 536 +++++++++++++++++++++++++-
> 1 file changed, 532 insertions(+), 4 deletions(-)
>
I remembered you pinged me in IRC about my previous review feedback.
Would appreciate if you could add a response email to your cover letter
explaining why that's not done.
I'm sure you're probably right but, good practice is to state in your
log what was and wasn't done and why.
---
bod
prev parent reply other threads:[~2024-04-24 0:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 17:03 [PATCH v3 0/4] MSM8976 MDSS/GPU/WCNSS support Adam Skladowski
2024-04-13 17:03 ` [PATCH v3 1/4] arm64: dts: qcom: msm8976: Add IOMMU nodes Adam Skladowski
2024-04-13 17:03 ` [PATCH v3 2/4] arm64: dts: qcom: msm8976: Add MDSS nodes Adam Skladowski
2024-04-23 16:27 ` Konrad Dybcio
2024-04-13 17:03 ` [PATCH v3 3/4] arm64: dts: qcom: msm8976: Add Adreno GPU Adam Skladowski
2024-04-23 16:28 ` Konrad Dybcio
2024-04-13 17:03 ` [PATCH v3 4/4] arm64: dts: qcom: msm8976: Add WCNSS node Adam Skladowski
2024-04-23 17:01 ` Konrad Dybcio
2024-04-24 0:01 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4028de21-33ea-4172-904f-e6809ef9a878@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).