From: Luca Weiss <luca@z3ntu.xyz>
To: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
"Bjorn Andersson" <andersson@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Stephan Gerhold" <stephan@gerhold.net>,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 power domains
Date: Sat, 10 Feb 2024 17:31:08 +0100 [thread overview]
Message-ID: <2171119.irdbgypaU6@z3ntu.xyz> (raw)
In-Reply-To: <18ae7906-5089-42b3-a511-6e301f116e06@linaro.org>
On Samstag, 10. Februar 2024 15:19:54 CET Konrad Dybcio wrote:
> On 2/10/24 15:12, Luca Weiss wrote:
> > Add the power domains CX & GFX found on devices with MSM8974 and PM8841.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
>
> [...]
>
> > +static struct rpmpd gfx_s4b_corner_ao;
> > +static struct rpmpd gfx_s4b_corner = {
> > + .pd = { .name = "gfx", },
> > + .peer = &gfx_s4b_corner_ao,
> > + .res_type = RPMPD_SMPB,
> > + .res_id = 4,
> > + .key = KEY_CORNER,
> > +};
> > +
> > +static struct rpmpd gfx_s4b_corner_ao = {
> > + .pd = { .name = "gfx_ao", },
> > + .peer = &gfx_s4b_corner,
> > + .active_only = true,
> > + .res_type = RPMPD_SMPB,
> > + .res_id = 4,
> > + .key = KEY_CORNER,
> > +};
>
> I don't see a s4b_ao downstream.. Though it's very unfortunate we
> didn't choose to add power-domain-cells or sth and set the bucket
> through that..
Right, overlooked that. Will drop gfx_ao for both this and the other patch.
Regards
Luca
>
> Konrad
next prev parent reply other threads:[~2024-02-10 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 14:12 [PATCH 0/3] Add RPMPD support for MSM8974 Luca Weiss
2024-02-10 14:12 ` [PATCH 1/3] dt-bindings: power: rpmpd: Add MSM8974 power domains Luca Weiss
2024-02-10 14:12 ` [PATCH 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 " Luca Weiss
2024-02-10 14:19 ` Konrad Dybcio
2024-02-10 16:31 ` Luca Weiss [this message]
2024-02-10 14:12 ` [PATCH 3/3] pmdomain: qcom: rpmpd: Add MSM8974PRO+PMA8084 " Luca Weiss
2024-02-10 14:23 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2171119.irdbgypaU6@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulf.hansson@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).