From: "Paul E. McKenney" <paulmck@kernel.org>
To: Alan Huang <mmpgouride@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] together: Fix the description of state traversal
Date: Fri, 2 Jun 2023 11:22:13 -0700 [thread overview]
Message-ID: <5cecd964-c3b4-4758-861b-407e93baebbe@paulmck-laptop> (raw)
In-Reply-To: <F67611BA-639A-40C6-9EA4-031B50D8B184@gmail.com>
On Tue, May 30, 2023 at 11:19:51PM +0800, Alan Huang wrote:
>
> > 2023年5月30日 08:40，Paul E. McKenney <paulmck@kernel.org> 写道：
> >
> > On Sun, May 28, 2023 at 04:40:20PM +0000, Alan Huang wrote:
> >> There seem to be some issues with the description of state transitions.
> >> This patch fixes that.
> >>
> >> Signed-off-by: Alan Huang <mmpgouride@gmail.com>
> >> ---
> >> together/applyrcu.tex | 7 ++++---
> >> 1 file changed, 4 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/together/applyrcu.tex b/together/applyrcu.tex
> >> index 09a265f7..dee027b9 100644
> >> --- a/together/applyrcu.tex
> >> +++ b/together/applyrcu.tex
> >> @@ -676,11 +676,12 @@ The normal path through this state machine traverses the states CLOSED,
> >> OPEN, CLOSING (with an invocation of \co{call_rcu()}), and back to CLOSED
> >> once the callback has been invoked.
> >> If \co{open()} is invoked before the grace period completes, the
> >> -state machine traverses the cycle OPEN, CLOSING (with an invocation
> >> -of \co{call_rcu()}), and back to CLOSED once the callback has been invoked.
> >> +state machine traverses the cycle OPEN, CLOSING (with
> >> +an invocation of \co{call_rcu()}), REOPENING, and back to OPEN once the
> >> +callback has been invoked.
> >> If \co{open()} and then \co{close()} are invoked before the grace period
> >> completes, the state machine traverses the cycle OPEN, CLOSING (with
> >> -an invocation of \co{call_rcu()}), REOPENING, and back to OPEN once the
> >> +an invocation of \co{call_rcu()}), REOPENING, RECLOSING, and back to CLOSING once the
> >> callback has been invoked.
> >
> > I took this patch (thank you!), but wonder if we should describe the
> > additional callback and additional transition to CLOSED, both here
> > and below. Thoughts?
>
> That would be more accurate. But the transition to CLOSED has already been
> described at the beginning of this paragraph. And omitting this description can
> encourage readers to engage in critical thinking and draw their own conclusions.
>
> But others may prefer more accurate explanations :)
>
> So, both descriptions work for me.
Fair enough, let's keep it as your patch has it for now. ;-)
Thanx, Paul
> Thanks,
> Alan
>
> >
> > Thanx, Paul
> >
> >> Given an indefinite alternating sequence of \co{close()} and \co{open()}
> >> --
> >> 2.34.1
> >>
>
prev parent reply other threads:[~2023-06-02 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 16:40 [PATCH] together: Fix the description of state traversal Alan Huang
2023-05-30 0:40 ` Paul E. McKenney
2023-05-30 15:19 ` Alan Huang
2023-06-02 18:22 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cecd964-c3b4-4758-861b-407e93baebbe@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=mmpgouride@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).