From: Akira Yokosawa <akiyks@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: "perfbook@vger.kernel.org" <perfbook@vger.kernel.org>,
Akira Yokosawa <akiyks@gmail.com>
Subject: [PATCH -perfbook] defer/rcuapi: Tweak Table E.3
Date: Mon, 12 Jun 2023 00:21:26 +0900 [thread overview]
Message-ID: <40ba8e60-0d3c-163d-e82c-801700aca13a@gmail.com> (raw)
Table E.3 is not intuitive enough to be understood on its own.
Make it self explanatory by adding references to Listing E.3 and
line counts.
Reorder header rows and use \cmidrule for better representation
of table structure as well.
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
Hi Paul,
I'm not sure if this is actually an improvement, but looking at
the line labels you put in the code snippet, I'm guessing this might
be along the line of what you had in mind.
What do you think?
Thanks, Akira
--
defer/rcuapi.tex | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/defer/rcuapi.tex b/defer/rcuapi.tex
index 3f5877f3264f..eea7259776d1 100644
--- a/defer/rcuapi.tex
+++ b/defer/rcuapi.tex
@@ -367,18 +367,23 @@ The \apik{rcu_barrier()} primitive does this job.
\renewcommand*{\arraystretch}{1.2}
\centering
\small
+\begin{fcvref}[ln:defer:synchonize-rcu vs rcu-barrier]
\begin{tabular}{lll}
\toprule
- & \tco{synchronize_rcu()} & \tco{rcu_barrier()} \\
-Invoked at: & \multicolumn{2}{c}{Must Wait Until:} \\
-\midrule
+ & \multicolumn{2}{c}{Must Wait Until (in \cref{lst:defer:synchronize-rcu vs. rcu-barrier}):} \\
+\cmidrule{2-3}
+\multicolumn{1}{c}{Invoked at:} & \multicolumn{1}{c}{\tco{synchronize_rcu()}}
+ & \multicolumn{1}{c}{\tco{rcu_barrier()}} \\
+\cmidrule(r){1-1} \cmidrule{2-3}
\tco{do_something_1()} & & \\
-\tco{do_something_2()} & \tco{rcu_read_unlock()} & \\
-\tco{do_something_3()} & \tco{rcu_read_unlock()} & \tco{f(&p->rh)} \\
-\tco{do_something_4()} & & \tco{f(&p->rh)} \\
+\tco{do_something_2()} & \tco{rcu_read_unlock()} (\clnref{rrul}) & \\
+\tco{do_something_3()} & \tco{rcu_read_unlock()} (\clnref{rrul})
+ & \tco{f(&p->rh)} (\clnref{cb}) \\
+\tco{do_something_4()} & & \tco{f(&p->rh)} (\clnref{cb}) \\
\tco{do_something_5()} & & \\
\bottomrule
\end{tabular}
+\end{fcvref}
\caption{\tco{synchronize_rcu()} vs. \tco{rcu_barrier()}}
\label{tab:defer:synchonize-rcu vs rcu-barrier}
\end{table*}
--
2.25.1
next reply other threads:[~2023-06-11 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 15:21 Akira Yokosawa [this message]
2023-06-11 16:30 ` [PATCH -perfbook] defer/rcuapi: Tweak Table E.3 Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40ba8e60-0d3c-163d-e82c-801700aca13a@gmail.com \
--to=akiyks@gmail.com \
--cc=paulmck@kernel.org \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).